Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Issue 2382653003: Enable GN build on Mac. (Closed)

Created:
4 years, 2 months ago by zra
Modified:
4 years, 2 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : Cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -15 lines) Patch
M build/config/mac/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M build/config/mac/mac_sdk.gni View 1 2 2 chunks +1 line, -12 lines 0 comments Download
M build/toolchain/mac/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn.py View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
4 years, 2 months ago (2016-09-29 20:39:17 UTC) #2
Cutch
lgtm
4 years, 2 months ago (2016-09-29 20:55:17 UTC) #3
zra
4 years, 2 months ago (2016-09-29 21:09:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
eb451292f9015cd9c417d2bb7460c3cf4b183ea5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698