Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1512)

Unified Diff: tools/gn.py

Issue 2382653003: Enable GN build on Mac. (Closed)
Patch Set: Cleanup Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/toolchain/mac/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn.py
diff --git a/tools/gn.py b/tools/gn.py
index 22f3530f0be19179935f94a06825f449b7a6a1eb..37aa885d1ec8983fe5ccf61d515b7e577369eb62 100755
--- a/tools/gn.py
+++ b/tools/gn.py
@@ -48,8 +48,11 @@ def target_cpu_for_arch(arch, os):
def to_gn_args(args):
gn_args = {}
+ host_os = HOST_OS
+ if HOST_OS == 'macos':
+ host_os = 'mac'
if args.os == 'host':
- gn_args['target_os'] = HOST_OS
+ gn_args['target_os'] = host_os
else:
gn_args['target_os'] = args.os
@@ -61,7 +64,7 @@ def to_gn_args(args):
# checked-in sdk. If/when the observatory no longer builds with the
# checked-in sdk, this can be removed.
gn_args['dart_host_pub_exe'] = os.path.join(
- DART_ROOT, 'tools', 'sdks', HOST_OS, 'dart-sdk', 'bin', 'pub')
+ DART_ROOT, 'tools', 'sdks', host_os, 'dart-sdk', 'bin', 'pub')
# For Fuchsia support, the default is to not compile in the root
# certificates.
« no previous file with comments | « build/toolchain/mac/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698