Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: extensions/common/view_type.h

Issue 238263004: Remove VIEW_TYPE_NOTIFICATION since it's not used anymore. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/extensions/runtime_custom_bindings.cc ('k') | extensions/common/view_type.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/view_type.h
===================================================================
--- extensions/common/view_type.h (revision 263855)
+++ extensions/common/view_type.h (working copy)
@@ -20,9 +20,6 @@
VIEW_TYPE_EXTENSION_DIALOG,
VIEW_TYPE_EXTENSION_INFOBAR,
VIEW_TYPE_EXTENSION_POPUP,
- // TODO(jam): remove this once http://crbug.com/137297 is fixed and HTML5
- // notifications don't use WebContents.
- VIEW_TYPE_NOTIFICATION,
VIEW_TYPE_PANEL,
VIEW_TYPE_TAB_CONTENTS,
VIEW_TYPE_VIRTUAL_KEYBOARD,
@@ -36,7 +33,6 @@
extern const char kViewTypeBackgroundPage[];
extern const char kViewTypeExtensionDialog[];
extern const char kViewTypeInfobar[];
-extern const char kViewTypeNotification[];
extern const char kViewTypePanel[];
extern const char kViewTypePopup[];
extern const char kViewTypeTabContents[];
« no previous file with comments | « chrome/renderer/extensions/runtime_custom_bindings.cc ('k') | extensions/common/view_type.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698