Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Side by Side Diff: extensions/common/view_type.h

Issue 238263004: Remove VIEW_TYPE_NOTIFICATION since it's not used anymore. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/renderer/extensions/runtime_custom_bindings.cc ('k') | extensions/common/view_type.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_COMMON_VIEW_TYPE_H_ 5 #ifndef EXTENSIONS_COMMON_VIEW_TYPE_H_
6 #define EXTENSIONS_COMMON_VIEW_TYPE_H_ 6 #define EXTENSIONS_COMMON_VIEW_TYPE_H_
7 7
8 namespace extensions { 8 namespace extensions {
9 9
10 // Icky RTTI used by a few systems to distinguish the host type of a given 10 // Icky RTTI used by a few systems to distinguish the host type of a given
11 // WebContents. 11 // WebContents.
12 // 12 //
13 // TODO(aa): Remove this and teach those systems to keep track of their own 13 // TODO(aa): Remove this and teach those systems to keep track of their own
14 // data. 14 // data.
15 enum ViewType { 15 enum ViewType {
16 VIEW_TYPE_INVALID, 16 VIEW_TYPE_INVALID,
17 VIEW_TYPE_APP_WINDOW, 17 VIEW_TYPE_APP_WINDOW,
18 VIEW_TYPE_BACKGROUND_CONTENTS, 18 VIEW_TYPE_BACKGROUND_CONTENTS,
19 VIEW_TYPE_EXTENSION_BACKGROUND_PAGE, 19 VIEW_TYPE_EXTENSION_BACKGROUND_PAGE,
20 VIEW_TYPE_EXTENSION_DIALOG, 20 VIEW_TYPE_EXTENSION_DIALOG,
21 VIEW_TYPE_EXTENSION_INFOBAR, 21 VIEW_TYPE_EXTENSION_INFOBAR,
22 VIEW_TYPE_EXTENSION_POPUP, 22 VIEW_TYPE_EXTENSION_POPUP,
23 // TODO(jam): remove this once http://crbug.com/137297 is fixed and HTML5
24 // notifications don't use WebContents.
25 VIEW_TYPE_NOTIFICATION,
26 VIEW_TYPE_PANEL, 23 VIEW_TYPE_PANEL,
27 VIEW_TYPE_TAB_CONTENTS, 24 VIEW_TYPE_TAB_CONTENTS,
28 VIEW_TYPE_VIRTUAL_KEYBOARD, 25 VIEW_TYPE_VIRTUAL_KEYBOARD,
29 VIEW_TYPE_LAST = VIEW_TYPE_VIRTUAL_KEYBOARD 26 VIEW_TYPE_LAST = VIEW_TYPE_VIRTUAL_KEYBOARD
30 }; 27 };
31 28
32 // Constant strings corresponding to the Type enumeration values. Used 29 // Constant strings corresponding to the Type enumeration values. Used
33 // when converting JS arguments. 30 // when converting JS arguments.
34 extern const char kViewTypeAll[]; 31 extern const char kViewTypeAll[];
35 extern const char kViewTypeAppWindow[]; 32 extern const char kViewTypeAppWindow[];
36 extern const char kViewTypeBackgroundPage[]; 33 extern const char kViewTypeBackgroundPage[];
37 extern const char kViewTypeExtensionDialog[]; 34 extern const char kViewTypeExtensionDialog[];
38 extern const char kViewTypeInfobar[]; 35 extern const char kViewTypeInfobar[];
39 extern const char kViewTypeNotification[];
40 extern const char kViewTypePanel[]; 36 extern const char kViewTypePanel[];
41 extern const char kViewTypePopup[]; 37 extern const char kViewTypePopup[];
42 extern const char kViewTypeTabContents[]; 38 extern const char kViewTypeTabContents[];
43 39
44 } // namespace extensions 40 } // namespace extensions
45 41
46 #endif // EXTENSIONS_COMMON_VIEW_TYPE_H_ 42 #endif // EXTENSIONS_COMMON_VIEW_TYPE_H_
OLDNEW
« no previous file with comments | « chrome/renderer/extensions/runtime_custom_bindings.cc ('k') | extensions/common/view_type.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698