CastRemotingConnector: Fix wrong assumption about MR route filtering.

CastRemotingConnector: Fix wrong assumption about MR route filtering.

CastRemotingConnector assumed the MediaRoutesObserver would filter out
routes to non-remoting MediaSources. This was not the case, and so new
filtering logic has been explicitly added in this change. Also, updated
unit tests to confirm filtering works.

Committed: https://crrev.com/9e3542eeb63982e7641f6ea85eac71b63fa8745b
Cr-Commit-Position: refs/heads/master@{#422021}

[miu, 2016-09-29 23:43:15]

The CQ bit was checked by miu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 23:43:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[miu, 2016-09-29 23:44:01]

miu@chromium.org changed reviewers:
+ xjz@chromium.org

[miu, 2016-09-29 23:44:01]

xjz: PTAL. This fixes the bug you encountered w/ extraneous calls to
OnSinkAvailable().

[commit-bot: I haz the power, 2016-09-30 00:23:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 00:23:46]

Dry run: This issue passed the CQ dry run.

[xjz, 2016-09-30 00:28:42]

lgtm

https://codereview.chromium.org/2382623003/diff/1/chrome/browser/media/cast_r...
File chrome/browser/media/cast_remoting_connector.h (right):

https://codereview.chromium.org/2382623003/diff/1/chrome/browser/media/cast_r...
chrome/browser/media/cast_remoting_connector.h:167: const
media_router::MediaSource::Id route_source_id_;
nit: media_source_id_?

[miu, 2016-09-30 02:51:23]

https://codereview.chromium.org/2382623003/diff/1/chrome/browser/media/cast_r...
File chrome/browser/media/cast_remoting_connector.h (right):

https://codereview.chromium.org/2382623003/diff/1/chrome/browser/media/cast_r...
chrome/browser/media/cast_remoting_connector.h:167: const
media_router::MediaSource::Id route_source_id_;
On 2016/09/30 00:28:42, xjz wrote:
> nit: media_source_id_?

Done.

[miu, 2016-09-30 02:51:28]

The CQ bit was checked by miu@chromium.org

[miu, 2016-09-30 02:51:28]

The patchset sent to the CQ was uploaded after l-g-t-m from xjz@chromium.org
Link to the patchset: https://codereview.chromium.org/2382623003/#ps20001
(title: "Tweak variable name.")

[commit-bot: I haz the power, 2016-09-30 02:51:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 03:49:36]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-30 03:51:45]

Description was changed from

==========
CastRemotingConnector: Fix wrong assumption about MR route filtering.

CastRemotingConnector assumed the MediaRoutesObserver would filter out
routes to non-remoting MediaSources. This was not the case, and so new
filtering logic has been explicitly added in this change. Also, updated
unit tests to confirm filtering works.
==========

to

==========
CastRemotingConnector: Fix wrong assumption about MR route filtering.

CastRemotingConnector assumed the MediaRoutesObserver would filter out
routes to non-remoting MediaSources. This was not the case, and so new
filtering logic has been explicitly added in this change. Also, updated
unit tests to confirm filtering works.

Committed: https://crrev.com/9e3542eeb63982e7641f6ea85eac71b63fa8745b
Cr-Commit-Position: refs/heads/master@{#422021}
==========

[commit-bot: I haz the power, 2016-09-30 03:51:47]

Patchset 2 (id:??) landed as
https://crrev.com/9e3542eeb63982e7641f6ea85eac71b63fa8745b
Cr-Commit-Position: refs/heads/master@{#422021}