CastRemotingConnector: Fix wrong assumption about MR route filtering.

chrome/browser/media/cast_remoting_connector_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/media/cast_remoting_connector.h"
 
 #include <utility>
 #include <vector>
 
 #include "base/callback.h"
@@ skipping 31 matching lines @@
 using ::testing::AtLeast;
 
 namespace {
 
 constexpr char kRemotingMediaSource[] =
     "urn:x-org.chromium.media:source:tab_content_remoting:123";
 constexpr char kRemotingMediaSink[] = "wiggles";
 constexpr char kRemotingMediaRoute[] =
     "urn:x-org.chromium:media:route:garbly_gook_ssi7m4oa8oma7rasd/cast-wiggles";
 
+constexpr char kTabMirroringMediaSource[] =
+    "urn:x-org.chromium.media:source:tab:123";
+constexpr char kTabMirroringMediaRoute[] =
+    "urn:x-org.chromium:media:route:bloopity_blop_ohun48i56nh9oid/cast-wiggles";
+
 // Implements basic functionality of a subset of the MediaRouter for use by the
 // unit tests in this module. Note that MockMediaRouter will complain at runtime
 // if any methods were called that should not have been called.
 class FakeMediaRouter : public media_router::MockMediaRouter {
  public:
   FakeMediaRouter()
       : routes_observer_(nullptr), message_observer_(nullptr),
         weak_factory_(this) {}
   ~FakeMediaRouter() final {}
 
   //
   // These methods are called by test code to create/destroy a media route and
   // pass messages in both directions.
   //
 
   void OnRemotingRouteExists(bool exists) {
     routes_.clear();
+
+    // Always add a non-remoting route to make sure CastRemotingConnector
+    // ignores non-remoting routes.
+    routes_.push_back(MediaRoute(
+        kTabMirroringMediaRoute, MediaSource(kTabMirroringMediaSource),
+        kRemotingMediaSink, "Cast Tab Mirroring", false, "", false));
+
     if (exists) {
       routes_.push_back(MediaRoute(
-          kRemotingMediaRoute, MediaSource(routes_observer_->source_id()),
+          kRemotingMediaRoute, MediaSource(kRemotingMediaSource),
           kRemotingMediaSink, "Cast Media Remoting", false, "", false));
     } else {
       // Cancel delivery of all messages in both directions.
       inbound_messages_.clear();
       for (const auto& entry : outbound_messages_) {
         BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
                                 base::Bind(entry.second, false));
       }
       outbound_messages_.clear();
     }
+
     BrowserThread::PostTask(
         BrowserThread::UI, FROM_HERE,
         base::Bind(&FakeMediaRouter::DoUpdateRoutes,
                    weak_factory_.GetWeakPtr()));
   }
 
   void OnMessageFromProvider(const std::string& message) {
     inbound_messages_.push_back(RouteMessage());
     inbound_messages_.back().type = RouteMessage::TEXT;
     inbound_messages_.back().text = message;
@@ skipping 126 matching lines @@
 
  private:
   mojo::Binding<media::mojom::RemotingSource> binding_;
 };
 
 }  // namespace
 
 class CastRemotingConnectorTest : public ::testing::Test {
  public:
   CastRemotingConnectorTest()
-      : remoting_source_(kRemotingMediaSource),
-        connector_(&media_router_, remoting_source_.id()) {}
+      : connector_(&media_router_, kRemotingMediaSource) {}
 
   void TearDown() final {
     // Allow any pending Mojo operations to complete before destruction. For
     // example, when one end of a Mojo message pipe is closed, a task is posted
     // to later destroy objects that were owned by the message pipe.
     RunUntilIdle();
   }
 
  protected:
   RemoterPtr CreateRemoter(MockRemotingSource* source) {
@@ skipping 69 matching lines @@
     media_router_.OnRemotingRouteExists(false);
   }
 
   static void RunUntilIdle() {
     base::RunLoop().RunUntilIdle();
   }
 
  private:
   content::TestBrowserThreadBundle browser_thread_bundle_;
   FakeMediaRouter media_router_;
-  const MediaSource remoting_source_;
   CastRemotingConnector connector_;
 };
 
 TEST_F(CastRemotingConnectorTest, NeverNotifiesThatSinkIsAvailable) {
   MockRemotingSource source;
   RemoterPtr remoter = CreateRemoter(&source);
 
   EXPECT_CALL(source, OnSinkAvailable()).Times(0);
   EXPECT_CALL(source, OnSinkGone()).Times(AtLeast(0));
   RunUntilIdle();
@@ skipping 257 matching lines @@
       break;
     }
   }
 }
 
 INSTANTIATE_TEST_CASE_P(, CastRemotingConnectorFullSessionTest,
                         ::testing::Values(SOURCE_TERMINATES,
                                           MOJO_PIPE_CLOSES,
                                           ROUTE_TERMINATES,
                                           EXTERNAL_FAILURE));