Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp

Issue 2382563002: Revert changes is the use of CompositingReasonOutOfFlowClipping
Patch Set: Add check for composited scrolling ancestor Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp
diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp
index b804e40dc567615791b155f1cad48df5b55a07f8..0adc936a55d43c145a1dd8d69af4dd2fe61cb6a8 100644
--- a/third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp
+++ b/third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp
@@ -288,7 +288,7 @@ void CompositingRequirementsUpdater::updateRecursive(
unclippedDescendants.remove(unclippedDescendantsToRemove.at(
unclippedDescendantsToRemove.size() - i - 1));
- if (layer->clipParent()) {
+ if (reasonsToComposite & CompositingReasonOutOfFlowClipping) {
// TODO(schenney): We only need to promote when the clipParent is not a descendant of the ancestor scroller,
// which we do not check for here. Hence we might be promoting needlessly.
unclippedDescendants.append(layer);
« no previous file with comments | « third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698