Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp

Issue 2382563002: Revert changes is the use of CompositingReasonOutOfFlowClipping
Patch Set: Add check for composited scrolling ancestor Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp
diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp
index 2924e5944e56d5997a4bf87d88cf8cb4b910d2b1..732e0b5ef280411f629f107826dcebad146b07ba 100644
--- a/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp
+++ b/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp
@@ -143,8 +143,17 @@ CompositingReasons CompositingReasonFinder::nonStyleDeterminedDirectReasons(
CompositingReasons directReasons = CompositingReasonNone;
LayoutObject* layoutObject = layer->layoutObject();
- if (layer->needsCompositedScrolling())
+ bool checkForClipParent =
+ (m_compositingTriggers & OverflowScrollTrigger) &&
+ layer->ancestorScrollingLayer() &&
+ layer->ancestorScrollingLayer()->compositingState() ==
+ PaintsIntoOwnBacking;
+ if (layer->needsCompositedScrolling()) {
+ checkForClipParent = true;
directReasons |= CompositingReasonOverflowScrollingTouch;
+ }
+ if (checkForClipParent && layer->clipParent())
+ directReasons |= CompositingReasonOutOfFlowClipping;
// Composite |layer| if it is inside of an ancestor scrolling layer, but that
// scrolling layer is not on the stacking context ancestor chain of |layer|.
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698