Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 2382523002: Revert of Revert r403630 which broke parsing on some sites. (Closed)

Created:
4 years, 2 months ago by jwd
Modified:
4 years, 2 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Revert of Revert r403630 which broke parsing on some sites. (patchset #1 id:1 of https://codereview.chromium.org/2380513002/ ) Reason for revert: BUILD.gn change missing from this merge, causing breakage on the Beta builders https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/precise64%20beta/builds/4150 ERROR at //testing/test.gni:271:5: Source file not found. executable(target_name) { ^------------------------ The target: //third_party/WebKit/Source/web:webkit_unit_tests has a source file: //third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulatorTest.cpp Original issue's description: > Revert r403630 which broke parsing on some sites. > > HTMLTreeBuilderSimulator needs to line up with HTML parsing. r403630 > tried to bring them closer together, but this regressed some existing > sites. This should be relanded but it needs to make the parser and > simulator more reliably consistent. > > BUG=542803, 639541 > > Review-Url: https://codereview.chromium.org/2366203006 > Cr-Commit-Position: refs/heads/master@{#421177} > (cherry picked from commit 6a454415188221d203662987d887c4ab70a2a877) > > Committed: https://chromium.googlesource.com/chromium/src/+/5b2166eee42a2936e0653929afb2595d614288fb TBR=dominicc@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=542803, 639541

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -36 lines) Patch
M third_party/WebKit/LayoutTests/fast/parser/comment-in-title.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/parser/comment-in-title-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.h View 3 chunks +30 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp View 3 chunks +74 lines, -25 lines 0 comments Download
A third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulatorTest.cpp View 1 chunk +72 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
jwd
Created Revert of Revert r403630 which broke parsing on some sites.
4 years, 2 months ago (2016-09-28 19:37:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2382523002/1
4 years, 2 months ago (2016-09-28 19:38:22 UTC) #3
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 19:41:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698