Chromium Code Reviews
DescriptionRevert of Revert r403630 which broke parsing on some sites. (patchset #1 id:1 of https://codereview.chromium.org/2380513002/ )
Reason for revert:
BUILD.gn change missing from this merge, causing breakage on the Beta builders https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/precise64%20beta/builds/4150
ERROR at //testing/test.gni:271:5: Source file not found.
executable(target_name) {
^------------------------
The target:
//third_party/WebKit/Source/web:webkit_unit_tests
has a source file:
//third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulatorTest.cpp
Original issue's description:
> Revert r403630 which broke parsing on some sites.
>
> HTMLTreeBuilderSimulator needs to line up with HTML parsing. r403630
> tried to bring them closer together, but this regressed some existing
> sites. This should be relanded but it needs to make the parser and
> simulator more reliably consistent.
>
> BUG=542803, 639541
>
> Review-Url: https://codereview.chromium.org/2366203006
> Cr-Commit-Position: refs/heads/master@{#421177}
> (cherry picked from commit 6a454415188221d203662987d887c4ab70a2a877)
>
> Committed: https://chromium.googlesource.com/chromium/src/+/5b2166eee42a2936e0653929afb2595d614288fb
TBR=dominicc@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=542803, 639541
Patch Set 1 #
Messages
Total messages: 5 (2 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||