Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2366203006: Revert r403630 which broke parsing on some sites. (Closed)

Created:
4 years, 2 months ago by dominicc (has gone to gerrit)
Modified:
4 years, 2 months ago
Reviewers:
kouhei (in TOK)
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch, loading-reviews+parser_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert r403630 which broke parsing on some sites. HTMLTreeBuilderSimulator needs to line up with HTML parsing. r403630 tried to bring them closer together, but this regressed some existing sites. This should be relanded but it needs to make the parser and simulator more reliably consistent. BUG=542803, 639541 Committed: https://crrev.com/6a454415188221d203662987d887c4ab70a2a877 Cr-Commit-Position: refs/heads/master@{#421177}

Patch Set 1 #

Patch Set 2 : Revert r403630 (by hand) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -178 lines) Patch
M third_party/WebKit/LayoutTests/fast/parser/comment-in-title.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/parser/comment-in-title-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.h View 4 chunks +8 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp View 3 chunks +23 lines, -72 lines 0 comments Download
D third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulatorTest.cpp View 1 chunk +0 lines, -72 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
dominicc (has gone to gerrit)
PTAL Manual revert.
4 years, 2 months ago (2016-09-27 07:57:42 UTC) #4
kouhei (in TOK)
lgtm
4 years, 2 months ago (2016-09-27 11:56:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366203006/20001
4 years, 2 months ago (2016-09-27 11:56:59 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-27 12:02:37 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 12:04:18 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6a454415188221d203662987d887c4ab70a2a877
Cr-Commit-Position: refs/heads/master@{#421177}

Powered by Google App Engine
This is Rietveld 408576698