Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Unified Diff: ui/views/style/platform_style_mac.mm

Issue 2382443007: Clean up NativeTheme (particularly CommonTheme). (Closed)
Patch Set: tdandersonreview Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ui/views/controls/label.cc ('K') | « ui/views/style/platform_style.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/style/platform_style_mac.mm
diff --git a/ui/views/style/platform_style_mac.mm b/ui/views/style/platform_style_mac.mm
index 707c2d9f1f31d36e61122853ea1419bec6853914..866bba64424ff4c8a7f9876c0567c8dbd7287280 100644
--- a/ui/views/style/platform_style_mac.mm
+++ b/ui/views/style/platform_style_mac.mm
@@ -80,10 +80,8 @@ SkColor PlatformStyle::TextColorForButton(
void PlatformStyle::ApplyLabelButtonTextStyle(
views::Label* label,
ButtonColorByState* color_by_state) {
- const ui::NativeTheme* theme = label->GetNativeTheme();
ButtonColorByState& colors = *color_by_state;
- colors[Button::STATE_PRESSED] =
- theme->GetSystemColor(ui::NativeTheme::kColorId_ButtonHighlightColor);
+ colors[Button::STATE_PRESSED] = SK_ColorWHITE;
sky 2016/10/03 16:12:05 How come there isn't a constant for this?
Evan Stade 2016/10/03 19:46:44 in what sense? Here in this file or in NativeTheme
sky 2016/10/03 21:25:15 Ok, fair enouh.
}
// static
« ui/views/controls/label.cc ('K') | « ui/views/style/platform_style.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698