Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1026)

Side by Side Diff: ui/views/style/platform_style_mac.mm

Issue 2382443007: Clean up NativeTheme (particularly CommonTheme). (Closed)
Patch Set: tdandersonreview Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« ui/views/controls/label.cc ('K') | « ui/views/style/platform_style.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/views/style/platform_style.h" 5 #include "ui/views/style/platform_style.h"
6 6
7 #include "base/memory/ptr_util.h" 7 #include "base/memory/ptr_util.h"
8 #include "ui/base/resource/resource_bundle.h" 8 #include "ui/base/resource/resource_bundle.h"
9 #include "ui/gfx/color_utils.h" 9 #include "ui/gfx/color_utils.h"
10 #include "ui/gfx/paint_vector_icon.h" 10 #include "ui/gfx/paint_vector_icon.h"
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 // the pressed state for default buttons. 73 // the pressed state for default buttons.
74 state = Button::STATE_PRESSED; 74 state = Button::STATE_PRESSED;
75 } 75 }
76 return color_by_state[state]; 76 return color_by_state[state];
77 } 77 }
78 78
79 // static 79 // static
80 void PlatformStyle::ApplyLabelButtonTextStyle( 80 void PlatformStyle::ApplyLabelButtonTextStyle(
81 views::Label* label, 81 views::Label* label,
82 ButtonColorByState* color_by_state) { 82 ButtonColorByState* color_by_state) {
83 const ui::NativeTheme* theme = label->GetNativeTheme();
84 ButtonColorByState& colors = *color_by_state; 83 ButtonColorByState& colors = *color_by_state;
85 colors[Button::STATE_PRESSED] = 84 colors[Button::STATE_PRESSED] = SK_ColorWHITE;
sky 2016/10/03 16:12:05 How come there isn't a constant for this?
Evan Stade 2016/10/03 19:46:44 in what sense? Here in this file or in NativeTheme
sky 2016/10/03 21:25:15 Ok, fair enouh.
86 theme->GetSystemColor(ui::NativeTheme::kColorId_ButtonHighlightColor);
87 } 85 }
88 86
89 // static 87 // static
90 void PlatformStyle::OnTextfieldKeypressUnhandled() { 88 void PlatformStyle::OnTextfieldKeypressUnhandled() {
91 NSBeep(); 89 NSBeep();
92 } 90 }
93 91
94 } // namespace views 92 } // namespace views
OLDNEW
« ui/views/controls/label.cc ('K') | « ui/views/style/platform_style.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698