chrome/browser/ui/views/toolbar/toolbar_action_view.cc - Issue 2382443007: Clean up NativeTheme (particularly CommonTheme).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/toolbar/toolbar_action_view.cc

Issue 2382443007: Clean up NativeTheme (particularly CommonTheme). (Closed)

Patch Set: two slight fixes Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/toolbar/toolbar_action_view.cc

diff --git a/chrome/browser/ui/views/toolbar/toolbar_action_view.cc b/chrome/browser/ui/views/toolbar/toolbar_action_view.cc

index 9c1669d08dd54b0f53fd1e3fd1bee9801fd1dd5f..ee3aa402e6ba97743147c22b68d310e8aa74885f 100644

--- a/chrome/browser/ui/views/toolbar/toolbar_action_view.cc

+++ b/chrome/browser/ui/views/toolbar/toolbar_action_view.cc

@@ -101,7 +101,7 @@ bool ToolbarActionView::IsTriggerableEvent(const ui::Event& event) {

SkColor ToolbarActionView::GetInkDropBaseColor() const {

if (delegate_->ShownInsideMenu()) {

return GetNativeTheme()->GetSystemColor(

- ui::NativeTheme::kColorId_HoverMenuItemBackgroundColor);

+ ui::NativeTheme::kColorId_FocusedMenuItemBackgroundColor);

Evan Stade 2016/09/30 18:02:36 as far as I can tell, "focused" and "hovered" are

tdanderson 2016/09/30 21:00:56 Acknowledged.

}

return GetThemeProvider()->GetColor(