Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(825)

Unified Diff: chrome/browser/ui/views/toolbar/app_menu.cc

Issue 2382443007: Clean up NativeTheme (particularly CommonTheme). (Closed)
Patch Set: two slight fixes Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/toolbar/app_menu.cc
diff --git a/chrome/browser/ui/views/toolbar/app_menu.cc b/chrome/browser/ui/views/toolbar/app_menu.cc
index 26839ed476a25d322e51562a9eacdf3091f22452..b7399bbe8c13f0396f108888b6cf5f064a147565 100644
--- a/chrome/browser/ui/views/toolbar/app_menu.cc
+++ b/chrome/browser/ui/views/toolbar/app_menu.cc
@@ -195,14 +195,12 @@ class InMenuButtonBackground : public views::Background {
views::Button::ButtonState state) {
const ui::NativeTheme* theme = view->GetNativeTheme();
switch (state) {
- case views::Button::STATE_HOVERED:
- // Hovered should be handled in DrawBackground.
- NOTREACHED();
- return theme->GetSystemColor(
- ui::NativeTheme::kColorId_HoverMenuItemBackgroundColor);
case views::Button::STATE_PRESSED:
return theme->GetSystemColor(
ui::NativeTheme::kColorId_FocusedMenuItemBackgroundColor);
+ case views::Button::STATE_HOVERED:
+ // Hovered should be handled in DrawBackground.
+ NOTREACHED();
default:
return theme->GetSystemColor(
ui::NativeTheme::kColorId_MenuBackgroundColor);

Powered by Google App Engine
This is Rietveld 408576698