Issue 2382443004: Replace a few more std::unique_ptr.reset() with WrapUnique assignments.

Issue 2382443004: Replace a few more std::unique_ptr.reset() with WrapUnique assignments. (Closed)

Created:
4 years, 2 months ago by Lei Zhang

Modified:
4 years, 2 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Target Ref:
refs/heads/master

Project:
pdfium

Visibility:
Public.

Replace a few more std::unique_ptr.reset() with WrapUnique assignments. And fix a typo. TBR=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/aca4fc767d663e43d323b96a75804a8f5cafd8d4

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -27 lines)			Patch
M	core/fpdfapi/fpdf_parser/include/cpdf_stream.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	core/fxcrt/fx_xml_parser.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	core/fxge/agg/fx_agg_driver.cpp	View	4 chunks	+6 lines, -6 lines	0 comments	Download
M	core/fxge/dib/fx_dib_engine.cpp	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	core/fxge/dib/fx_dib_main.cpp	View	4 chunks	+6 lines, -6 lines	0 comments	Download
M	core/fxge/dib/fx_dib_transform.cpp	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	core/fxge/ge/cfx_font.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	core/fxge/ge/cfx_fontmgr.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	testing/js_embedder_test.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 10 (6 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2382443004/1

4 years, 2 months ago (2016-09-29 05:06:05 UTC) #7

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://pdfium.googlesource.com/pdfium/+/aca4fc767d663e43d323b96a75804a8f5cafd8d4

4 years, 2 months ago (2016-09-29 05:06:24 UTC) #9

Message was sent while issue was closed.

lgtm