core/fxcrt/fx_xml_parser.cpp - Issue 2382443004: Replace a few more std::unique_ptr.reset() with WrapUnique assignments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fxcrt/fx_xml_parser.cpp

Issue 2382443004: Replace a few more std::unique_ptr.reset() with WrapUnique assignments. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fxcrt/fx_xml_parser.cpp

diff --git a/core/fxcrt/fx_xml_parser.cpp b/core/fxcrt/fx_xml_parser.cpp

index 9412cdde04192ee4a3611c1bf4b0aaa8930dd7a8..926196786ab496052da1eb17fac0d0b12813cbf4 100644

--- a/core/fxcrt/fx_xml_parser.cpp

+++ b/core/fxcrt/fx_xml_parser.cpp

@@ -894,7 +894,7 @@ void CXML_AttrMap::SetAt(const CFX_ByteString& space,

const CFX_ByteString& name,

const CFX_WideString& value) {

if (!m_pMap)

- m_pMap.reset(new std::vector<CXML_AttrItem>);

+ m_pMap = WrapUnique(new std::vector<CXML_AttrItem>);

for (CXML_AttrItem& item : *m_pMap) {

if (item.Matches(space, name)) {

« no previous file with comments | « core/fpdfapi/fpdf_parser/include/cpdf_stream.h ('k') | core/fxge/agg/fx_agg_driver.cpp » ('j') | no next file with comments »