Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 2382173002: Don't allow form-feed (U+000C) as a WebVTT signature separator (Closed)

Created:
4 years, 2 months ago by fs
Modified:
4 years, 2 months ago
Reviewers:
foolip
CC:
fs, blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, gasubic, mlamouri+watch-blink_chromium.org, nessy, Srirama, vcarbune.chromium
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't allow form-feed (U+000C) as a WebVTT signature separator Per the WebVTT parser algorithm [1], only space, tab or newline (after normalization) are allowed to follow the "WEBVTT" signature. [1] https://w3c.github.io/webvtt/#webvtt-parser-algorithm BUG=651777 Committed: https://crrev.com/84007ecf0f27d2074c70955d43cc1743ee39980a Cr-Commit-Position: refs/heads/master@{#422093}

Patch Set 1 #

Patch Set 2 : Typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -45 lines) Patch
D third_party/WebKit/LayoutTests/media/track/opera/track/webvtt/parsing/001-expected.txt View 1 chunk +0 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/vtt/VTTParser.h View 2 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp View 1 2 chunks +13 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
fs
4 years, 2 months ago (2016-09-30 11:59:11 UTC) #6
foolip
lgtm
4 years, 2 months ago (2016-09-30 13:08:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2382173002/20001
4 years, 2 months ago (2016-09-30 13:08:39 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-30 13:13:20 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 13:15:21 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/84007ecf0f27d2074c70955d43cc1743ee39980a
Cr-Commit-Position: refs/heads/master@{#422093}

Powered by Google App Engine
This is Rietveld 408576698