Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: third_party/WebKit/Source/core/html/track/vtt/VTTParser.h

Issue 2382173002: Don't allow form-feed (U+000C) as a WebVTT signature separator (Closed)
Patch Set: Typo Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/track/vtt/VTTParser.h
diff --git a/third_party/WebKit/Source/core/html/track/vtt/VTTParser.h b/third_party/WebKit/Source/core/html/track/vtt/VTTParser.h
index cdfe47800d200750bc7a2beb69158fc055ba9fee..daf324bb08c55fd29e4ccf5e853be0f163e20c23 100644
--- a/third_party/WebKit/Source/core/html/track/vtt/VTTParser.h
+++ b/third_party/WebKit/Source/core/html/track/vtt/VTTParser.h
@@ -58,6 +58,8 @@ public:
DEFINE_INLINE_VIRTUAL_TRACE() { }
};
+// Implementation of the WebVTT parser algorithm.
+// https://w3c.github.io/webvtt/#webvtt-parser-algorithm
class VTTParser final : public GarbageCollectedFinalized<VTTParser> {
public:
enum ParseState {
@@ -87,7 +89,9 @@ public:
}
static inline bool isASpace(UChar c)
{
- // WebVTT space characters are U+0020 SPACE, U+0009 CHARACTER TABULATION (tab), U+000A LINE FEED (LF), U+000C FORM FEED (FF), and U+000D CARRIAGE RETURN (CR).
+ // WebVTT space characters are U+0020 SPACE, U+0009 CHARACTER
+ // TABULATION (tab), U+000A LINE FEED (LF), U+000C FORM FEED (FF), and
+ // U+000D CARRIAGE RETURN (CR).
return c == ' ' || c == '\t' || c == '\n' || c == '\f' || c == '\r';
}
static inline bool isValidSettingDelimiter(UChar c)

Powered by Google App Engine
This is Rietveld 408576698