[Turbofan] Streamline InstructionOperand predicate methods.

[Turbofan] Streamline InstructionOperand predicate methods.
- Orders machine representations so it's easier to check for floating
point.
- Orders operand types so it's easier to check for LocationOperands.
- Adds IsLocation, IsFPLocation predicates.

LOG=N
BUG=v8:4124
Committed: https://crrev.com/b5c9e31c975e5a15fb93d4cc75d7ae7c36b43b4a
Cr-Commit-Position: refs/heads/master@{#39941}

[bbudge, 2016-09-30 19:48:52]

The CQ bit was checked by bbudge@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 19:49:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bbudge, 2016-09-30 19:51:32]

The CQ bit was checked by bbudge@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 19:51:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 20:24:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 20:24:32]

Dry run: This issue passed the CQ dry run.

[bbudge, 2016-09-30 20:38:07]

bbudge@chromium.org changed reviewers:
+ danno@chromium.org, mtrofin@chromium.org

[bbudge, 2016-09-30 20:38:08]

More preparation for re-adding aliasing support on ARM

[Mircea Trofin, 2016-09-30 21:52:10]

lgtm after comments

https://codereview.chromium.org/2382013003/diff/20001/src/compiler/instruction.h
File src/compiler/instruction.h (right):

https://codereview.chromium.org/2382013003/diff/20001/src/compiler/instructio...
src/compiler/instruction.h:77: inline bool IsLocation() const;
As discussed offline, how about these names:

IsLocation -> IsAnyLocationOperand
IsFPLocation->IsFPLocationOperand

add
IsLocationOperand
IsAnyStackSlot

https://codereview.chromium.org/2382013003/diff/20001/src/machine-type.h
File src/machine-type.h (right):

https://codereview.chromium.org/2382013003/diff/20001/src/machine-type.h#newc...
src/machine-type.h:28: // FP representations must be last, and in order of
increasing size.
consider adding a marker here (kFirstFloat) and then the comparisons are
from it

[bbudge, 2016-10-02 17:56:22]

The CQ bit was checked by bbudge@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-02 17:56:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-02 18:24:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-02 18:24:17]

Dry run: This issue passed the CQ dry run.

[bbudge, 2016-10-03 20:58:37]

The CQ bit was checked by bbudge@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 20:58:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 21:34:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 21:34:42]

Dry run: This issue passed the CQ dry run.

[bbudge, 2016-10-03 21:37:02]

The CQ bit was checked by bbudge@chromium.org

[bbudge, 2016-10-03 21:37:02]

The patchset sent to the CQ was uploaded after l-g-t-m from mtrofin@chromium.org
Link to the patchset: https://codereview.chromium.org/2382013003/#ps60001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-10-03 21:37:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bbudge, 2016-10-03 21:37:18]

https://codereview.chromium.org/2382013003/diff/20001/src/compiler/instruction.h
File src/compiler/instruction.h (right):

https://codereview.chromium.org/2382013003/diff/20001/src/compiler/instructio...
src/compiler/instruction.h:77: inline bool IsLocation() const;
On 2016/09/30 21:52:10, Mircea Trofin wrote:
> As discussed offline, how about these names:
> 
> IsLocation -> IsAnyLocationOperand
> IsFPLocation->IsFPLocationOperand
> 
> add
> IsLocationOperand
> IsAnyStackSlot
> 

Done.

https://codereview.chromium.org/2382013003/diff/20001/src/machine-type.h
File src/machine-type.h (right):

https://codereview.chromium.org/2382013003/diff/20001/src/machine-type.h#newc...
src/machine-type.h:28: // FP representations must be last, and in order of
increasing size.
On 2016/09/30 21:52:10, Mircea Trofin wrote:
> consider adding a marker here (kFirstFloat) and then the comparisons are
> from it

kFirstFPRepresentation

Done.

[commit-bot: I haz the power, 2016-10-03 21:39:29]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-03 21:39:55]

Description was changed from

==========
[Turbofan] Streamline InstructionOperand predicate methods.
- Orders machine representations so it's easier to check for floating
point.
- Orders operand types so it's easier to check for LocationOperands.
- Adds IsLocation, IsFPLocation predicates.

LOG=N
BUG=v8:4124
==========

to

==========
[Turbofan] Streamline InstructionOperand predicate methods.
- Orders machine representations so it's easier to check for floating
point.
- Orders operand types so it's easier to check for LocationOperands.
- Adds IsLocation, IsFPLocation predicates.

LOG=N
BUG=v8:4124

Committed: https://crrev.com/b5c9e31c975e5a15fb93d4cc75d7ae7c36b43b4a
Cr-Commit-Position: refs/heads/master@{#39941}
==========

[commit-bot: I haz the power, 2016-10-03 21:39:56]

Patchset 4 (id:??) landed as
https://crrev.com/b5c9e31c975e5a15fb93d4cc75d7ae7c36b43b4a
Cr-Commit-Position: refs/heads/master@{#39941}