[Turbofan] Streamline InstructionOperand predicate methods.

src/machine-type.h

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_MACHINE_TYPE_H_
 #define V8_MACHINE_TYPE_H_
 
 #include <iosfwd>
 
 #include "src/base/bits.h"
 #include "src/globals.h"
 #include "src/signature.h"
 #include "src/zone/zone.h"
 
 namespace v8 {
 namespace internal {
 
 enum class MachineRepresentation : uint8_t {
   kNone,
   kBit,
   kWord8,
   kWord16,
   kWord32,
   kWord64,
-  kFloat32,
-  kFloat64,  // must follow kFloat32
-  kSimd128,  // must follow kFloat64
   kTaggedSigned,
   kTaggedPointer,
-  kTagged
+  kTagged,
+  // FP representations must be last, and in order of increasing size.

[Mircea Trofin, 2016/09/30 21:52:10]

consider adding a marker here (kFirstFloat) and then the comparisons are
from it

[bbudge, 2016/10/03 21:37:18]

kFirstFPRepresentation

Done.

+  kFloat32,
+  kFloat64,
+  kSimd128
 };
 
 const char* MachineReprToString(MachineRepresentation);
 
 enum class MachineSemantic : uint8_t {
   kNone,
   kBool,
   kInt32,
   kUint32,
   kInt64,
@@ skipping 176 matching lines @@
   return static_cast<size_t>(type.representation()) +
          static_cast<size_t>(type.semantic()) * 16;
 }
 
 V8_EXPORT_PRIVATE std::ostream& operator<<(std::ostream& os,
                                            MachineRepresentation rep);
 std::ostream& operator<<(std::ostream& os, MachineSemantic type);
 std::ostream& operator<<(std::ostream& os, MachineType type);
 
 inline bool IsFloatingPoint(MachineRepresentation rep) {
-  return rep == MachineRepresentation::kFloat32 ||
-         rep == MachineRepresentation::kFloat64 ||
-         rep == MachineRepresentation::kSimd128;
+  return rep >= MachineRepresentation::kFloat32;
 }
 
 inline bool CanBeTaggedPointer(MachineRepresentation rep) {
   return rep == MachineRepresentation::kTagged ||
          rep == MachineRepresentation::kTaggedPointer;
 }
 
 inline bool IsAnyTagged(MachineRepresentation rep) {
   return CanBeTaggedPointer(rep) || rep == MachineRepresentation::kTaggedSigned;
 }
@@ skipping 24 matching lines @@
   UNREACHABLE();
   return -1;
 }
 
 typedef Signature<MachineType> MachineSignature;
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_MACHINE_TYPE_H_