Source/core/css/resolver/MatchedPropertiesCache.cpp - Issue 23819007: Have Node::document() return a reference instead of a pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/resolver/MatchedPropertiesCache.cpp

Issue 23819007: Have Node::document() return a reference instead of a pointer (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase on master Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/resolver/MatchedPropertiesCache.cpp

diff --git a/Source/core/css/resolver/MatchedPropertiesCache.cpp b/Source/core/css/resolver/MatchedPropertiesCache.cpp

index 1b0946d534fff02975249dcdfa95c1f763ca5afe..eb984abcbf8c40f2c029464e40b4ad045be823e1 100644

--- a/Source/core/css/resolver/MatchedPropertiesCache.cpp

+++ b/Source/core/css/resolver/MatchedPropertiesCache.cpp

@@ -115,7 +115,7 @@ void MatchedPropertiesCache::sweep(Timer<MatchedPropertiesCache>*)

bool MatchedPropertiesCache::isCacheable(const Element* element, const RenderStyle* style, const RenderStyle* parentStyle)

{

// FIXME: CSSPropertyWebkitWritingMode modifies state when applying to document element. We can't skip the applying by caching.

- if (element == element->document()->documentElement() && element->document()->writingModeSetOnDocumentElement())

+ if (element == element->document().documentElement() && element->document().writingModeSetOnDocumentElement())

return false;

if (style->unique() || (style->styleType() != NOPSEUDO && parentStyle->unique()))

return false;