Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: tools/perf/benchmarks/v8.py

Issue 2381863002: Re-enable all v8 benchmarks on reference (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/v8.py
diff --git a/tools/perf/benchmarks/v8.py b/tools/perf/benchmarks/v8.py
index 25db8e949a4f66d776a0a678e79a66b936aa8a3c..167c07a7603012ebdcb1d490395df86f471e3348 100644
--- a/tools/perf/benchmarks/v8.py
+++ b/tools/perf/benchmarks/v8.py
@@ -137,9 +137,6 @@ class V8TodoMVC(perf_benchmark.PerfBenchmark):
return True
-# Disabled on reference builds because they don't support the new
-# Tracing.requestMemoryDump DevTools API. See http://crbug.com/540022.
-@benchmark.Disabled('reference')
class V8TodoMVCIgnition(V8TodoMVC):
"""Measures V8 Execution metrics on the TodoMVC examples using ignition."""
page_set = page_sets.TodoMVCPageSet
@@ -153,9 +150,6 @@ class V8TodoMVCIgnition(V8TodoMVC):
return 'v8.todomvc-ignition'
-# Disabled on reference builds because they don't support the new
-# Tracing.requestMemoryDump DevTools API. See http://crbug.com/540022.
-@benchmark.Disabled('reference')
class V8InfiniteScroll(_InfiniteScrollBenchmark):
"""Measures V8 GC metrics and memory usage while scrolling the top web pages.
http://www.chromium.org/developers/design-documents/rendering-benchmarks"""
@@ -167,9 +161,6 @@ class V8InfiniteScroll(_InfiniteScrollBenchmark):
return 'v8.infinite_scroll_tbmv2'
-# Disabled on reference builds because they don't support the new
-# Tracing.requestMemoryDump DevTools API. See http://crbug.com/540022.
-@benchmark.Disabled('reference') # crbug.com/579546
class V8InfiniteScrollIgnition(V8InfiniteScroll):
"""Measures V8 GC metrics using Ignition."""
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698