Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: tools/perf/benchmarks/v8.py

Issue 2381863002: Re-enable all v8 benchmarks on reference (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 import os 4 import os
5 5
6 from core import path_util 6 from core import path_util
7 from core import perf_benchmark 7 from core import perf_benchmark
8 from page_sets import google_pages 8 from page_sets import google_pages
9 9
10 from benchmarks import v8_helper 10 from benchmarks import v8_helper
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 def ShouldDisable(cls, possible_browser): 130 def ShouldDisable(cls, possible_browser):
131 # This benchmark is flaky on Samsung Galaxy S5s. 131 # This benchmark is flaky on Samsung Galaxy S5s.
132 # http://crbug.com/644826 132 # http://crbug.com/644826
133 return possible_browser.platform.GetDeviceTypeName() == 'SM-G900H' 133 return possible_browser.platform.GetDeviceTypeName() == 'SM-G900H'
134 134
135 @classmethod 135 @classmethod
136 def ShouldTearDownStateAfterEachStoryRun(cls): 136 def ShouldTearDownStateAfterEachStoryRun(cls):
137 return True 137 return True
138 138
139 139
140 # Disabled on reference builds because they don't support the new
141 # Tracing.requestMemoryDump DevTools API. See http://crbug.com/540022.
142 @benchmark.Disabled('reference')
143 class V8TodoMVCIgnition(V8TodoMVC): 140 class V8TodoMVCIgnition(V8TodoMVC):
144 """Measures V8 Execution metrics on the TodoMVC examples using ignition.""" 141 """Measures V8 Execution metrics on the TodoMVC examples using ignition."""
145 page_set = page_sets.TodoMVCPageSet 142 page_set = page_sets.TodoMVCPageSet
146 143
147 def SetExtraBrowserOptions(self, options): 144 def SetExtraBrowserOptions(self, options):
148 super(V8TodoMVCIgnition, self).SetExtraBrowserOptions(options) 145 super(V8TodoMVCIgnition, self).SetExtraBrowserOptions(options)
149 v8_helper.EnableIgnition(options) 146 v8_helper.EnableIgnition(options)
150 147
151 @classmethod 148 @classmethod
152 def Name(cls): 149 def Name(cls):
153 return 'v8.todomvc-ignition' 150 return 'v8.todomvc-ignition'
154 151
155 152
156 # Disabled on reference builds because they don't support the new
157 # Tracing.requestMemoryDump DevTools API. See http://crbug.com/540022.
158 @benchmark.Disabled('reference')
159 class V8InfiniteScroll(_InfiniteScrollBenchmark): 153 class V8InfiniteScroll(_InfiniteScrollBenchmark):
160 """Measures V8 GC metrics and memory usage while scrolling the top web pages. 154 """Measures V8 GC metrics and memory usage while scrolling the top web pages.
161 http://www.chromium.org/developers/design-documents/rendering-benchmarks""" 155 http://www.chromium.org/developers/design-documents/rendering-benchmarks"""
162 156
163 page_set = page_sets.InfiniteScrollPageSet 157 page_set = page_sets.InfiniteScrollPageSet
164 158
165 @classmethod 159 @classmethod
166 def Name(cls): 160 def Name(cls):
167 return 'v8.infinite_scroll_tbmv2' 161 return 'v8.infinite_scroll_tbmv2'
168 162
169 163
170 # Disabled on reference builds because they don't support the new
171 # Tracing.requestMemoryDump DevTools API. See http://crbug.com/540022.
172 @benchmark.Disabled('reference') # crbug.com/579546
173 class V8InfiniteScrollIgnition(V8InfiniteScroll): 164 class V8InfiniteScrollIgnition(V8InfiniteScroll):
174 """Measures V8 GC metrics using Ignition.""" 165 """Measures V8 GC metrics using Ignition."""
175 166
176 def SetExtraBrowserOptions(self, options): 167 def SetExtraBrowserOptions(self, options):
177 super(V8InfiniteScrollIgnition, self).SetExtraBrowserOptions(options) 168 super(V8InfiniteScrollIgnition, self).SetExtraBrowserOptions(options)
178 v8_helper.EnableIgnition(options) 169 v8_helper.EnableIgnition(options)
179 170
180 @classmethod 171 @classmethod
181 def Name(cls): 172 def Name(cls):
182 return 'v8.infinite_scroll-ignition_tbmv2' 173 return 'v8.infinite_scroll-ignition_tbmv2'
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
230 return True 221 return True
231 # http://crbug.com/623576 222 # http://crbug.com/623576
232 if (possible_browser.platform.GetDeviceTypeName() == 'Nexus 5' or 223 if (possible_browser.platform.GetDeviceTypeName() == 'Nexus 5' or
233 possible_browser.platform.GetDeviceTypeName() == 'Nexus 7'): 224 possible_browser.platform.GetDeviceTypeName() == 'Nexus 7'):
234 return True 225 return True
235 return False 226 return False
236 227
237 @classmethod 228 @classmethod
238 def ShouldTearDownStateAfterEachStoryRun(cls): 229 def ShouldTearDownStateAfterEachStoryRun(cls):
239 return True 230 return True
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698