Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issue 2381853003: Add bot-page summary with utilization stats (Closed)

Created:
4 years, 2 months ago by kjlubick
Modified:
4 years, 2 months ago
Reviewers:
KevinL, jcgregorio, stephana
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org, M-A Ruel
Base URL:
git@github.com:luci/luci-py@page-everywhere
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Add bot-page summary with utilization stats You can ignore most of the bot-page changes - they are mostly whitespace changes. BUG=631047 Committed: https://github.com/luci/luci-py/commit/5808042b94ab28b513bc3e1e7cab0a1c7b74881f

Patch Set 1 #

Patch Set 2 : I like how it looks #

Patch Set 3 : Move lib to third_party #

Patch Set 4 : Fix now #

Patch Set 5 : rebase #

Total comments: 1

Patch Set 6 : Remove common-strings from third_party #

Patch Set 7 : Fix right margins #

Patch Set 8 : Update gitignore #

Total comments: 2

Patch Set 9 : address spaces #

Unified diffs Side-by-side diffs Delta from patch set Stats (+531 lines, -109 lines) Patch
M appengine/swarming/elements/.gitignore View 1 2 3 4 5 6 7 1 chunk +2 lines, -1 line 0 comments Download
M appengine/swarming/elements/Makefile View 1 2 3 4 5 6 7 3 chunks +29 lines, -10 lines 0 comments Download
M appengine/swarming/elements/build/elements.html View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M appengine/swarming/elements/build/js/js.js View 1 1 chunk +2 lines, -1 line 0 comments Download
M appengine/swarming/elements/package.json View 1 1 chunk +3 lines, -2 lines 0 comments Download
M appengine/swarming/elements/res/imp/botpage/bot-page.html View 1 2 3 4 5 chunks +110 lines, -94 lines 0 comments Download
M appengine/swarming/elements/res/imp/botpage/bot-page-data.html View 1 chunk +1 line, -0 lines 0 comments Download
M appengine/swarming/elements/res/imp/botpage/bot-page-demo.html View 1 2 3 4 5 2 chunks +5 lines, -0 lines 0 comments Download
A appengine/swarming/elements/res/imp/botpage/bot-page-summary.html View 1 2 3 4 5 6 7 8 1 chunk +378 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 16 (7 generated)
kjlubick
Live on https://2365-bd022ad-tainted-kjlubick-dot-chromium-swarm-dev.appspot.com/newui/bot?id=skia-rpi-test&sort_stats=total%3Adesc Better mock data at https://goto.google.com/exfpx https://screenshot.googleplex.com/JKUOkZAVf5B If there are a lot of ...
4 years, 2 months ago (2016-09-30 20:25:28 UTC) #4
jcgregorio
https://codereview.chromium.org/2381853003/diff/80001/appengine/swarming/elements/third_party/common-strings.js File appengine/swarming/elements/third_party/common-strings.js (right): https://codereview.chromium.org/2381853003/diff/80001/appengine/swarming/elements/third_party/common-strings.js#newcode1 appengine/swarming/elements/third_party/common-strings.js:1: (function(){ What is the license for these libraries? Why ...
4 years, 2 months ago (2016-10-03 15:15:28 UTC) #5
kjlubick
On 2016/10/03 at 15:15:28, jcgregorio wrote: > https://codereview.chromium.org/2381853003/diff/80001/appengine/swarming/elements/third_party/common-strings.js > File appengine/swarming/elements/third_party/common-strings.js (right): > > https://codereview.chromium.org/2381853003/diff/80001/appengine/swarming/elements/third_party/common-strings.js#newcode1 ...
4 years, 2 months ago (2016-10-03 15:21:32 UTC) #6
kjlubick
On 2016/10/03 at 15:21:32, kjlubick wrote: > On 2016/10/03 at 15:15:28, jcgregorio wrote: > > ...
4 years, 2 months ago (2016-10-03 17:59:10 UTC) #7
jcgregorio
lgtm https://codereview.chromium.org/2381853003/diff/140001/appengine/swarming/elements/res/imp/botpage/bot-page-summary.html File appengine/swarming/elements/res/imp/botpage/bot-page-summary.html (right): https://codereview.chromium.org/2381853003/diff/140001/appengine/swarming/elements/res/imp/botpage/bot-page-summary.html#newcode37 appengine/swarming/elements/res/imp/botpage/bot-page-summary.html:37: paper-checkbox { blank line between styles.
4 years, 2 months ago (2016-10-03 20:12:20 UTC) #8
kjlubick
https://codereview.chromium.org/2381853003/diff/140001/appengine/swarming/elements/res/imp/botpage/bot-page-summary.html File appengine/swarming/elements/res/imp/botpage/bot-page-summary.html (right): https://codereview.chromium.org/2381853003/diff/140001/appengine/swarming/elements/res/imp/botpage/bot-page-summary.html#newcode37 appengine/swarming/elements/res/imp/botpage/bot-page-summary.html:37: paper-checkbox { On 2016/10/03 at 20:12:20, jcgregorio wrote: > ...
4 years, 2 months ago (2016-10-03 20:14:44 UTC) #9
KevinL
lgtm
4 years, 2 months ago (2016-10-03 20:15:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2381853003/160001
4 years, 2 months ago (2016-10-03 20:16:00 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 20:19:38 UTC) #16
Message was sent while issue was closed.
Committed patchset #9 (id:160001) as
https://github.com/luci/luci-py/commit/5808042b94ab28b513bc3e1e7cab0a1c7b74881f

Powered by Google App Engine
This is Rietveld 408576698