Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2375963003: Move bot-list and task-list to use pageable-data (Closed)

Created:
4 years, 2 months ago by kjlubick
Modified:
4 years, 2 months ago
Reviewers:
KevinL, stephana
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org, jcgregorio, M-A Ruel
Base URL:
git@github.com:luci/luci-py@limit-tasks
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Move bot-list and task-list to use pageable-data BUG=631047 Committed: https://github.com/luci/luci-py/commit/d453ab391f618bbae7f3a7293edb265c1b5542d1

Patch Set 1 #

Patch Set 2 : Add _showEvents to be explicit #

Patch Set 3 : rebase #

Total comments: 2

Patch Set 4 : rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+242 lines, -184 lines) Patch
M appengine/swarming/elements/build/elements.html View 1 2 3 4 chunks +131 lines, -100 lines 0 comments Download
M appengine/swarming/elements/res/imp/botlist/bot-list.html View 1 2 3 7 chunks +36 lines, -4 lines 0 comments Download
M appengine/swarming/elements/res/imp/botlist/bot-list-data.html View 7 chunks +9 lines, -37 lines 0 comments Download
M appengine/swarming/elements/res/imp/common/dynamic-table-behavior.html View 1 chunk +1 line, -1 line 0 comments Download
M appengine/swarming/elements/res/imp/common/pageable-data.html View 4 chunks +13 lines, -5 lines 0 comments Download
M appengine/swarming/elements/res/imp/tasklist/task-list.html View 1 2 7 chunks +37 lines, -6 lines 0 comments Download
M appengine/swarming/elements/res/imp/tasklist/task-list-data.html View 1 2 6 chunks +15 lines, -31 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (5 generated)
kjlubick
https://screenshot.googleplex.com/PFgeQxFFmaY https://screenshot.googleplex.com/fY3zx4roy7w See it live at https://2365-bd022ad-tainted-kjlubick-dot-chromium-swarm-dev.appspot.com/newui/botlist?c=id&c=os&c=task&c=status&l=100&s=id%3Aasc
4 years, 2 months ago (2016-09-28 15:27:34 UTC) #2
stephana
lgtm modulo one nit https://codereview.chromium.org/2375963003/diff/40001/appengine/swarming/elements/res/imp/botlist/bot-list.html File appengine/swarming/elements/res/imp/botlist/bot-list.html (right): https://codereview.chromium.org/2375963003/diff/40001/appengine/swarming/elements/res/imp/botlist/bot-list.html#newcode541 appengine/swarming/elements/res/imp/botlist/bot-list.html:541: reload: function() { Should be ...
4 years, 2 months ago (2016-10-03 17:34:58 UTC) #3
KevinL
lgtm
4 years, 2 months ago (2016-10-03 18:02:33 UTC) #5
kjlubick
https://codereview.chromium.org/2375963003/diff/40001/appengine/swarming/elements/res/imp/botlist/bot-list.html File appengine/swarming/elements/res/imp/botlist/bot-list.html (right): https://codereview.chromium.org/2375963003/diff/40001/appengine/swarming/elements/res/imp/botlist/bot-list.html#newcode541 appengine/swarming/elements/res/imp/botlist/bot-list.html:541: reload: function() { On 2016/10/03 at 17:34:57, stephana wrote: ...
4 years, 2 months ago (2016-10-03 18:03:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2375963003/60001
4 years, 2 months ago (2016-10-03 18:06:22 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 18:09:21 UTC) #11
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://github.com/luci/luci-py/commit/d453ab391f618bbae7f3a7293edb265c1b5542d1

Powered by Google App Engine
This is Rietveld 408576698