[SPInvalidation] Don't flip local paint invalidation rect for non-root SVG

[SPInvalidation] Don't flip local paint invalidation rect for non-root SVG

Writing-mode flipping doesn't apply to non-root SVG.

This fixes failures of the svg layout tests containing vertical text
in slimmingPaintInvalidation mode.

BUG=646176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/ff856adbb42ddeef1b97fe45c0790ff270bca9ce
Cr-Commit-Position: refs/heads/master@{#421872}

[Xianzhu, 2016-09-29 04:40:14]

Description was changed from

==========
Don't flip local paint invalidation rect for non-root SVG

For non-root SVG, the local paint invalidation rect is already in
physical coordinates, so no need to flip.

This fixes failures of the svg layout tests containing vertical text
in slimmingPaintInvalidation.

BUG=646176
==========

to

==========
Don't flip local paint invalidation rect for non-root SVG

For non-root SVG, the local paint invalidation rect is already in
physical coordinates, so no need to flip.

This fixes failures of the svg layout tests containing vertical text
in slimmingPaintInvalidation.

BUG=646176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2016-09-29 04:40:19]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 04:40:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 06:19:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 06:19:55]

Dry run: This issue passed the CQ dry run.

[Xianzhu, 2016-09-29 16:14:23]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org

[Xianzhu, 2016-09-29 16:15:49]

Description was changed from

==========
Don't flip local paint invalidation rect for non-root SVG

For non-root SVG, the local paint invalidation rect is already in
physical coordinates, so no need to flip.

This fixes failures of the svg layout tests containing vertical text
in slimmingPaintInvalidation.

BUG=646176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
[SPInvalidation] Don't flip local paint invalidation rect for non-root SVG

For non-root SVG, the local paint invalidation rect is already in
physical coordinates, so no need to flip.

This fixes failures of the svg layout tests containing vertical text
in slimmingPaintInvalidation.

BUG=646176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2016-09-29 16:16:06]

Description was changed from

==========
[SPInvalidation] Don't flip local paint invalidation rect for non-root SVG

For non-root SVG, the local paint invalidation rect is already in
physical coordinates, so no need to flip.

This fixes failures of the svg layout tests containing vertical text
in slimmingPaintInvalidation.

BUG=646176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
[SPInvalidation] Don't flip local paint invalidation rect for non-root SVG

For non-root SVG, the local paint invalidation rect is already in
physical coordinates, so no need to flip.

This fixes failures of the svg layout tests containing vertical text
in slimmingPaintInvalidation mode.

BUG=646176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2016-09-29 16:41:59]

https://codereview.chromium.org/2381793002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/PaintInvalidator.cpp (right):

https://codereview.chromium.org/2381793002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/PaintInvalidator.cpp:48: if
(!object.isSVG() || object.isSVGRoot()) {
Can you point me to the equivalent SPv1 code?

[Xianzhu, 2016-09-29 16:57:50]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 16:58:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-09-29 17:00:56]

https://codereview.chromium.org/2381793002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/PaintInvalidator.cpp (right):

https://codereview.chromium.org/2381793002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/PaintInvalidator.cpp:48: if
(!object.isSVG() || object.isSVGRoot()) {
On 2016/09/29 16:41:59, chrishtr wrote:
> Can you point me to the equivalent SPv1 code?

https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/Pa...

In SPv1, we are using a different path of paint invalidation rect calculation
for SVG v1, so the flipping at
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/Pa...
won't apply to non-root SVG.

I changed the comment to "Writing-mode flipping doesn't apply to non-root SVG".

[chrishtr, 2016-09-29 17:02:11]

On 2016/09/29 at 17:00:56, wangxianzhu wrote:
>
https://codereview.chromium.org/2381793002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/paint/PaintInvalidator.cpp (right):
> 
>
https://codereview.chromium.org/2381793002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/paint/PaintInvalidator.cpp:48: if
(!object.isSVG() || object.isSVGRoot()) {
> On 2016/09/29 16:41:59, chrishtr wrote:
> > Can you point me to the equivalent SPv1 code?
> 
>
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/Pa...
> 
> In SPv1, we are using a different path of paint invalidation rect calculation
for SVG v1, so the flipping at
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/Pa...
won't apply to non-root SVG.

Because it always uses the fast path?

> 
> I changed the comment to "Writing-mode flipping doesn't apply to non-root
SVG".

[chrishtr, 2016-09-29 17:02:40]

On 2016/09/29 at 17:02:11, chrishtr wrote:
> On 2016/09/29 at 17:00:56, wangxianzhu wrote:
> >
https://codereview.chromium.org/2381793002/diff/1/third_party/WebKit/Source/c...
> > File third_party/WebKit/Source/core/paint/PaintInvalidator.cpp (right):
> > 
> >
https://codereview.chromium.org/2381793002/diff/1/third_party/WebKit/Source/c...
> > third_party/WebKit/Source/core/paint/PaintInvalidator.cpp:48: if
(!object.isSVG() || object.isSVGRoot()) {
> > On 2016/09/29 16:41:59, chrishtr wrote:
> > > Can you point me to the equivalent SPv1 code?
> > 
> >
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/Pa...
> > 
> > In SPv1, we are using a different path of paint invalidation rect
calculation for SVG v1, so the flipping at
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/Pa...
won't apply to non-root SVG.
> 
> Because it always uses the fast path?
> 
> > 
> > I changed the comment to "Writing-mode flipping doesn't apply to non-root
SVG".

Oh I see.

[chrishtr, 2016-09-29 17:03:00]

lgtm

[Xianzhu, 2016-09-29 17:04:07]

Description was changed from

==========
[SPInvalidation] Don't flip local paint invalidation rect for non-root SVG

For non-root SVG, the local paint invalidation rect is already in
physical coordinates, so no need to flip.

This fixes failures of the svg layout tests containing vertical text
in slimmingPaintInvalidation mode.

BUG=646176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
[SPInvalidation] Don't flip local paint invalidation rect for non-root SVG

Writing-mode flipping doesn't apply to non-root SVG.

This fixes failures of the svg layout tests containing vertical text
in slimmingPaintInvalidation mode.

BUG=646176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2016-09-29 17:05:55]

On 2016/09/29 17:02:11, chrishtr wrote:
> On 2016/09/29 at 17:00:56, wangxianzhu wrote:
> >
>
https://codereview.chromium.org/2381793002/diff/1/third_party/WebKit/Source/c...
> > File third_party/WebKit/Source/core/paint/PaintInvalidator.cpp (right):
> > 
> >
>
https://codereview.chromium.org/2381793002/diff/1/third_party/WebKit/Source/c...
> > third_party/WebKit/Source/core/paint/PaintInvalidator.cpp:48: if
> (!object.isSVG() || object.isSVGRoot()) {
> > On 2016/09/29 16:41:59, chrishtr wrote:
> > > Can you point me to the equivalent SPv1 code?
> > 
> >
>
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/Pa...
> > 
> > In SPv1, we are using a different path of paint invalidation rect
calculation
> for SVG v1, so the flipping at
>
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/Pa...
> won't apply to non-root SVG.
> 
> Because it always uses the fast path?
> 

SVG has its own version of slow path:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/Pa...

> > 
> > I changed the comment to "Writing-mode flipping doesn't apply to non-root
> SVG".

[Xianzhu, 2016-09-29 17:06:01]

The CQ bit was unchecked by wangxianzhu@chromium.org

[Xianzhu, 2016-09-29 17:06:06]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-09-29 17:06:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 18:11:30]

Description was changed from

==========
[SPInvalidation] Don't flip local paint invalidation rect for non-root SVG

Writing-mode flipping doesn't apply to non-root SVG.

This fixes failures of the svg layout tests containing vertical text
in slimmingPaintInvalidation mode.

BUG=646176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
[SPInvalidation] Don't flip local paint invalidation rect for non-root SVG

Writing-mode flipping doesn't apply to non-root SVG.

This fixes failures of the svg layout tests containing vertical text
in slimmingPaintInvalidation mode.

BUG=646176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[commit-bot: I haz the power, 2016-09-29 18:11:31]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-29 18:16:21]

Description was changed from

==========
[SPInvalidation] Don't flip local paint invalidation rect for non-root SVG

Writing-mode flipping doesn't apply to non-root SVG.

This fixes failures of the svg layout tests containing vertical text
in slimmingPaintInvalidation mode.

BUG=646176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
[SPInvalidation] Don't flip local paint invalidation rect for non-root SVG

Writing-mode flipping doesn't apply to non-root SVG.

This fixes failures of the svg layout tests containing vertical text
in slimmingPaintInvalidation mode.

BUG=646176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/ff856adbb42ddeef1b97fe45c0790ff270bca9ce
Cr-Commit-Position: refs/heads/master@{#421872}
==========

[commit-bot: I haz the power, 2016-09-29 18:16:22]

Patchset 2 (id:??) landed as
https://crrev.com/ff856adbb42ddeef1b97fe45c0790ff270bca9ce
Cr-Commit-Position: refs/heads/master@{#421872}