[SPInvalidation] Don't flip local paint invalidation rect for non-root SVG

third_party/WebKit/Source/core/paint/PaintInvalidator.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/paint/PaintInvalidator.h"
 
 #include "core/editing/FrameSelection.h"
 #include "core/frame/FrameView.h"
 #include "core/frame/LocalFrame.h"
 #include "core/frame/Settings.h"
@@ skipping 26 matching lines @@
 }
 
 // TODO(wangxianzhu): Combine this into PaintInvalidator::mapLocalRectToPaintInvalidationBacking() when removing PaintInvalidationState.
 static LayoutRect mapLocalRectToPaintInvalidationBacking(GeometryMapper& geometryMapper, const LayoutObject& object, const FloatRect& localRect, const PaintInvalidatorContext& context)
 {
     // TODO(wkorman): The flip below is required because visual rects are
     // currently in "physical coordinates with flipped block-flow direction"
     // (see LayoutBoxModelObject.h) but we need them to be in physical
     // coordinates.
     FloatRect rect = localRect;
-    if (object.isBox()) {
-        toLayoutBox(object).flipForWritingMode(rect);
-    } else if (!(context.forcedSubtreeInvalidationFlags & PaintInvalidatorContext::ForcedSubtreeSlowPathRect)) {
-        // For SPv2 and the GeometryMapper path, we also need to convert the rect
-        // for non-boxes into physical coordinates before applying paint offset.
-        // (Otherwise we'll call mapToVisualrectInAncestorSpace() which requires
-        // physical coordinates for boxes, but "physical coordinates with flipped
-        // block-flow direction" for non-boxes for which we don't need to flip.)
-        // TODO(wangxianzhu): Avoid containingBlock().
-        object.containingBlock()->flipForWritingMode(rect);
+    // For non-root SVG, localRect is already in physical coordinates.
+    if (!object.isSVG() || object.isSVGRoot()) {

[chrishtr, 2016/09/29 16:41:59]

Can you point me to the equivalent SPv1 code?

[Xianzhu, 2016/09/29 17:00:55]

https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/Pa...

In SPv1, we are using a different path of paint invalidation rect calculation
for SVG v1, so the flipping at
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/Pa...
won't apply to non-root SVG.

I changed the comment to "Writing-mode flipping doesn't apply to non-root SVG".

+        if (object.isBox()) {
+            toLayoutBox(object).flipForWritingMode(rect);
+        } else if (!(context.forcedSubtreeInvalidationFlags & PaintInvalidatorContext::ForcedSubtreeSlowPathRect)) {
+            // For SPv2 and the GeometryMapper path, we also need to convert the rect
+            // for non-boxes into physical coordinates before applying paint offset.
+            // (Otherwise we'll call mapToVisualrectInAncestorSpace() which requires
+            // physical coordinates for boxes, but "physical coordinates with flipped
+            // block-flow direction" for non-boxes for which we don't need to flip.)
+            // TODO(wangxianzhu): Avoid containingBlock().
+            object.containingBlock()->flipForWritingMode(rect);
+        }
     }
 
     if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
         // In SPv2, visual rects are in the space of their local transform node.
         rect.moveBy(FloatPoint(context.treeBuilderContext.current.paintOffset));
         return LayoutRect(rect);
     }
 
     LayoutRect result;
     if (context.forcedSubtreeInvalidationFlags & PaintInvalidatorContext::ForcedSubtreeSlowPathRect) {
@@ skipping 246 matching lines @@
     object.getMutableForPainting().clearPaintInvalidationFlags();
 }
 
 void PaintInvalidator::processPendingDelayedPaintInvalidations()
 {
     for (auto target : m_pendingDelayedPaintInvalidations)
         target->getMutableForPainting().setShouldDoFullPaintInvalidation(PaintInvalidationDelayedFull);
 }
 
 } // namespace blink