Issue 2381723002: Replace std::unique_ptr.reset() with WrapUnique assignment.

Issue 2381723002: Replace std::unique_ptr.reset() with WrapUnique assignment. (Closed)

Created:
4 years, 2 months ago by Lei Zhang

Modified:
4 years, 2 months ago

Reviewers:
Tom Sepez, Wei Li

CC:
pdfium-reviews_googlegroups.com

Target Ref:
refs/heads/master

Project:
pdfium

Visibility:
Public.

Replace std::unique_ptr.reset() with WrapUnique assignment. fpdfsdk/ edition. Committed: https://pdfium.googlesource.com/pdfium/+/d4c34f208aa3b76c5941395823c6dcf6bb7e2f34

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -25 lines)			Patch
M	fpdfsdk/cpdfsdk_document.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	fpdfsdk/cpdfsdk_environment.cpp	View		2 chunks	+5 lines, -3 lines	0 comments	Download
M	fpdfsdk/cpdfsdk_pageview.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	fpdfsdk/formfiller/cffl_listbox.cpp	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	fpdfsdk/formfiller/cffl_textfield.cpp	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	fpdfsdk/fpdf_dataavail.cpp	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	fpdfsdk/fpdfdoc_unittest.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	fpdfsdk/fpdfview.cpp	View		3 chunks	+5 lines, -4 lines	0 comments	Download
M	fpdfsdk/fpdfxfa/fpdfxfa_app.cpp	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	fpdfsdk/fpdfxfa/fpdfxfa_page.cpp	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	fpdfsdk/fxedit/fxet_edit.cpp	View		4 chunks	+4 lines, -3 lines	0 comments	Download
M	fpdfsdk/javascript/JS_Runtime_Stub.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	fpdfsdk/pdfwindow/PWL_FontMap.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	fpdfsdk/pdfwindow/PWL_ListBox.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	fpdfsdk/pdfwindow/PWL_Wnd.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 15 (11 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2381723002/20001

4 years, 2 months ago (2016-09-29 00:04:35 UTC) #13

commit-bot: I haz the power

4 years, 2 months ago (2016-09-29 00:04:54 UTC) #15

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/d4c34f208aa3b76c5941395823c6dcf6bb7e...