Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Side by Side Diff: fpdfsdk/fpdfdoc_unittest.cpp

Issue 2381723002: Replace std::unique_ptr.reset() with WrapUnique assignment. (Closed)
Patch Set: build Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « fpdfsdk/fpdf_dataavail.cpp ('k') | fpdfsdk/fpdfview.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 PDFium Authors. All rights reserved. 1 // Copyright 2016 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "public/fpdf_doc.h" 5 #include "public/fpdf_doc.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <vector> 8 #include <vector>
9 9
10 #include "core/fpdfapi/fpdf_parser/include/cpdf_document.h" 10 #include "core/fpdfapi/fpdf_parser/include/cpdf_document.h"
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 uint32_t num; 54 uint32_t num;
55 CPDF_Dictionary* obj; 55 CPDF_Dictionary* obj;
56 }; 56 };
57 57
58 void SetUp() override { 58 void SetUp() override {
59 // We don't need page module or render module, but 59 // We don't need page module or render module, but
60 // initialize them to keep the code sane. 60 // initialize them to keep the code sane.
61 CPDF_ModuleMgr* module_mgr = CPDF_ModuleMgr::Get(); 61 CPDF_ModuleMgr* module_mgr = CPDF_ModuleMgr::Get();
62 module_mgr->InitPageModule(); 62 module_mgr->InitPageModule();
63 63
64 m_pDoc.reset(new CPDF_TestPdfDocument()); 64 m_pDoc = WrapUnique(new CPDF_TestPdfDocument());
65 m_pIndirectObjs = m_pDoc->GetHolder(); 65 m_pIndirectObjs = m_pDoc->GetHolder();
66 // Setup the root directory. 66 // Setup the root directory.
67 m_pRootObj.reset(new CPDF_Dictionary()); 67 m_pRootObj.reset(new CPDF_Dictionary());
68 m_pDoc->SetRoot(m_pRootObj.get()); 68 m_pDoc->SetRoot(m_pRootObj.get());
69 } 69 }
70 70
71 void TearDown() override { 71 void TearDown() override {
72 m_pRootObj.reset(); 72 m_pRootObj.reset();
73 m_pIndirectObjs = nullptr; 73 m_pIndirectObjs = nullptr;
74 m_pDoc.reset(); 74 m_pDoc.reset();
(...skipping 149 matching lines...) Expand 10 before | Expand all | Expand 10 after
224 // Title with no match. 224 // Title with no match.
225 std::unique_ptr<unsigned short, pdfium::FreeDeleter> title = 225 std::unique_ptr<unsigned short, pdfium::FreeDeleter> title =
226 GetFPDFWideString(L"Chapter 8"); 226 GetFPDFWideString(L"Chapter 8");
227 EXPECT_EQ(nullptr, FPDFBookmark_Find(m_pDoc.get(), title.get())); 227 EXPECT_EQ(nullptr, FPDFBookmark_Find(m_pDoc.get(), title.get()));
228 228
229 // Title with a match. 229 // Title with a match.
230 title = GetFPDFWideString(L"Chapter 3"); 230 title = GetFPDFWideString(L"Chapter 3");
231 EXPECT_EQ(bookmarks[3].obj, FPDFBookmark_Find(m_pDoc.get(), title.get())); 231 EXPECT_EQ(bookmarks[3].obj, FPDFBookmark_Find(m_pDoc.get(), title.get()));
232 } 232 }
233 } 233 }
OLDNEW
« no previous file with comments | « fpdfsdk/fpdf_dataavail.cpp ('k') | fpdfsdk/fpdfview.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698