Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2381293002: misc files: Change ScopedTempDir::path() to GetPath() (Closed)

Created:
4 years, 2 months ago by vabr (Chromium)
Modified:
4 years, 2 months ago
Reviewers:
asanka, Finnur
CC:
asanka, chromium-apps-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, extensions-reviews_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

misc files: Change ScopedTempDir::path() to GetPath() path() is being deprecated, GetPath() has better checking against wrong use. For more context, see https://codereview.chromium.org/2275553005/. BUG=640599 TBR=finnur@chromium.org, asanka@chromium.org Committed: https://crrev.com/a247e7f5846c814ec88bccd8296a88883d6c68c8 Cr-Commit-Position: refs/heads/master@{#422082}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M content/browser/download/base_file_win_unittest.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M content/browser/download/quarantine_win_unittest.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M extensions/browser/content_hash_fetcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (9 generated)
vabr (Chromium)
Hello finnur@ and asanka@. I put you in TBR for extensions/browser* (finnur) and content/browser/download (asanka). ...
4 years, 2 months ago (2016-09-30 11:36:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2381293002/1
4 years, 2 months ago (2016-09-30 11:36:45 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-30 11:42:11 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a247e7f5846c814ec88bccd8296a88883d6c68c8 Cr-Commit-Position: refs/heads/master@{#422082}
4 years, 2 months ago (2016-09-30 11:43:46 UTC) #13
asanka
lgtm
4 years, 2 months ago (2016-09-30 13:44:15 UTC) #14
Finnur
4 years, 2 months ago (2016-10-03 11:32:38 UTC) #15
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698