Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2381053002: Reland "[builtins] migrate C++ String Iterator builtins to baseline TurboFan" (Closed)

Created:
4 years, 2 months ago by caitp
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "[builtins] migrate C++ String Iterator builtins to baseline TurboFan" Migrate newly added C++ String Iterator builtins to TFJ builtins, per step 4. of the String Iterator Baseline Implementation section of the design doc BUG=v8:5388 R=bmeurer@chromium.org, mstarzinger@chromium.org, jkummerow@chromium.org Committed: https://crrev.com/f9a2c8b1112c4e915df8bc5f7ea1fccdf7a33ff8 Cr-Commit-Position: refs/heads/master@{#39765} patch from issue 2358263002 at patchset 260001 (http://crrev.com/2358263002#ps260001) Committed: https://crrev.com/3c52ac79cd32f203e35fb0426cc6b28c533ce0ed Cr-Commit-Position: refs/heads/master@{#39879}

Patch Set 1 #

Patch Set 2 : Add the fix and test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+509 lines, -46 lines) Patch
M src/bootstrapper.cc View 1 chunk +11 lines, -3 lines 0 comments Download
M src/builtins/builtins.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/builtins/builtins-string.cc View 1 1 chunk +425 lines, -40 lines 0 comments Download
M src/code-stub-assembler.h View 2 chunks +9 lines, -0 lines 0 comments Download
M src/code-stub-assembler.cc View 1 chunk +52 lines, -0 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/mjsunit/es6/string-iterator.js View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
caitp
Here's a fix (and test case) for the infinite loop in the sliced string case.
4 years, 2 months ago (2016-09-29 15:05:52 UTC) #4
Jakob Kummerow
The fix LGTM (only looked at diff from patch set 1 -> 2).
4 years, 2 months ago (2016-09-29 15:13:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2381053002/20001
4 years, 2 months ago (2016-09-29 15:47:30 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-29 15:49:15 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 15:49:33 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3c52ac79cd32f203e35fb0426cc6b28c533ce0ed
Cr-Commit-Position: refs/heads/master@{#39879}

Powered by Google App Engine
This is Rietveld 408576698