src/objects-debug.cc - Issue 2381053002: Reland "[builtins] migrate C++ String Iterator builtins to baseline TurboFan"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-debug.cc

Issue 2381053002: Reland "[builtins] migrate C++ String Iterator builtins to baseline TurboFan" (Closed)

Patch Set: Add the fix and test Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects-debug.cc

diff --git a/src/objects-debug.cc b/src/objects-debug.cc

index 21f51e67045840bbef1c87e36229683b75620339..5902e0dda8cd6cc0ac47362849e6aa9a381f7a26 100644

--- a/src/objects-debug.cc

+++ b/src/objects-debug.cc

@@ -785,7 +785,8 @@ void JSWeakMap::JSWeakMapVerify() {

void JSStringIterator::JSStringIteratorVerify() {

CHECK(IsJSStringIterator());

JSObjectVerify();

- CHECK(string()->IsString());

+ CHECK(string()->IsSeqString() || string()->IsExternalString());

CHECK_GE(index(), 0);

CHECK_LE(index(), String::kMaxLength);

}

« no previous file with comments | « src/code-stub-assembler.cc ('k') | test/mjsunit/es6/string-iterator.js » ('j') | no next file with comments »