Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2381023003: Retry WebAPK download if fails for the first time. (Closed)

Created:
4 years, 2 months ago by pkotwicz
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Retry WebAPK download if fails for the first time. The WebAPK server may send us the URL of the WebAPK to download prior to the WebAPK being available at that URL. WebApkInstaller will sleep 2 seconds and retry the download if the download fails. BUG=649704 TBR=dfalcantara Committed: https://crrev.com/ace8dc83ee038e907dcb14ce09cd7e6584f315e3 Cr-Commit-Position: refs/heads/master@{#422583}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Merge branch 'master' into hanxi_cl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -3 lines) Patch
M chrome/browser/android/webapk/webapk_installer.h View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/android/webapk/webapk_installer.cc View 1 1 chunk +21 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
pkotwicz
I am landing this CL on behalf of hanxi@. This CL is copied and pasted ...
4 years, 2 months ago (2016-09-29 19:24:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2381023003/1
4 years, 2 months ago (2016-09-29 19:24:28 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/39321)
4 years, 2 months ago (2016-09-29 20:08:22 UTC) #6
pkotwicz
https://codereview.chromium.org/2381023003/diff/1/chrome/browser/android/webapk/webapk_installer.cc File chrome/browser/android/webapk/webapk_installer.cc (right): https://codereview.chromium.org/2381023003/diff/1/chrome/browser/android/webapk/webapk_installer.cc#newcode427 chrome/browser/android/webapk/webapk_installer.cc:427: downloader_.reset(); I removed this from the diff. It looks ...
4 years, 2 months ago (2016-10-03 21:30:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2381023003/20001
4 years, 2 months ago (2016-10-03 21:32:43 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-03 23:00:33 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 23:03:24 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ace8dc83ee038e907dcb14ce09cd7e6584f315e3
Cr-Commit-Position: refs/heads/master@{#422583}

Powered by Google App Engine
This is Rietveld 408576698