Retry WebAPK download if fails for the first time.

chrome/browser/android/webapk/webapk_installer.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/webapk/webapk_installer.h"
 
 #include "base/android/build_info.h"
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
 #include "base/android/path_utils.h"
@@ skipping 384 matching lines @@
                  weak_ptr_factory_.GetWeakPtr(), download_url));
 }
 
 void WebApkInstaller::OnCreatedSubDirAndSetPermissions(
     const GURL& download_url, const base::FilePath& output_dir) {
   if (output_dir.empty()) {
     OnFailure();
     return;
   }
 
+  DownloadWebApk(output_dir.AppendASCII(webapk_package_), download_url, true);
+}
+
+void WebApkInstaller::DownloadWebApk(const base::FilePath& output_path,
+                                     const GURL& download_url,
+                                     bool retry_if_fails) {
   timer_.Start(
       FROM_HERE, base::TimeDelta::FromMilliseconds(download_timeout_ms_),
       base::Bind(&WebApkInstaller::OnTimeout, weak_ptr_factory_.GetWeakPtr()));
 
-  base::FilePath output_path = output_dir.AppendASCII(webapk_package_);
   downloader_.reset(new FileDownloader(
       download_url, output_path, true, request_context_getter_,
       base::Bind(&WebApkInstaller::OnWebApkDownloaded,
-                 weak_ptr_factory_.GetWeakPtr(), output_path)));
+                 weak_ptr_factory_.GetWeakPtr(),
+                 output_path, download_url, retry_if_fails)));
 }
 
 void WebApkInstaller::OnWebApkDownloaded(const base::FilePath& file_path,
+                                         const GURL& download_url,
+                                         bool retry_if_fails,
                                          FileDownloader::Result result) {
   timer_.Stop();
+  downloader_.reset();

[pkotwicz, 2016/10/03 21:30:56]

I removed this from the diff.

It looks like base::Callback does not like getting deleted while it is being run

 
   if (result != FileDownloader::DOWNLOADED) {
-    OnFailure();
+    if (!retry_if_fails) {
+      OnFailure();
+      return;
+    }
+
+    content::BrowserThread::PostDelayedTask(
+        content::BrowserThread::UI, FROM_HERE,
+        base::Bind(&WebApkInstaller::DownloadWebApk,
+                   weak_ptr_factory_.GetWeakPtr(),
+                   file_path, download_url, false),
+        base::TimeDelta::FromSeconds(2));
     return;
   }
 
   int posix_permissions = kWorldReadableFilePermission |
                           base::FILE_PERMISSION_WRITE_BY_USER |
                           base::FILE_PERMISSION_EXECUTE_BY_USER;
   base::PostTaskAndReplyWithResult(
       GetBackgroundTaskRunner().get(), FROM_HERE,
       base::Bind(&base::SetPosixFilePermissions, file_path, posix_permissions),
       base::Bind(&WebApkInstaller::OnWebApkMadeWorldReadable,
@@ skipping 39 matching lines @@
   std::string webapk_package = webapk_package_;
   delete this;
   callback.Run(true, webapk_package);
 }
 
 void WebApkInstaller::OnFailure() {
   FinishCallback callback = finish_callback_;
   delete this;
   callback.Run(false, "");
 }