Give PlatformNotificationAction's scalar type field a default value

Give PlatformNotificationAction's scalar type field a default value

- This fixes the underlying reason for the uninit warning in
PlatformNotificationServiceTest.DisplayPersistentNotificationMatches
by initializing the field in PlatformNotificationAction's constructor.

BUG=599859, 651165
Committed: https://crrev.com/0463eb5e689328081e71de001f621fefed5b737c
Cr-Commit-Position: refs/heads/master@{#421840}

[awdf, 2016-09-29 12:55:50]

awdf@chromium.org changed reviewers:
+ awdf@chromium.org, peter@chromium.org

[Peter Beverloo, 2016-09-29 12:58:05]

lgtm!

You still need OWNERS for //content/public/, maybe try avi@?

[awdf, 2016-09-29 13:00:00]

awdf@chromium.org changed reviewers:
+ avi@chromium.org

[awdf, 2016-09-29 13:00:01]

avi@chromium.org: Please review changes in

content/public

[Avi (use Gerrit), 2016-09-29 13:51:32]

lgtm

Yep!

[awdf, 2016-09-29 14:09:13]

The CQ bit was checked by awdf@chromium.org

[commit-bot: I haz the power, 2016-09-29 14:09:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2016-09-29 15:32:10]

thestig@chromium.org changed reviewers:
+ thestig@chromium.org

[Lei Zhang, 2016-09-29 15:32:11]

Do you want to undo my action initialization in
chrome/browser/notifications/platform_notification_service_unittest.cc then?

[awdf, 2016-09-29 16:08:36]

On 2016/09/29 15:32:11, Lei Zhang wrote:
> Do you want to undo my action initialization in
> chrome/browser/notifications/platform_notification_service_unittest.cc then?

Good point that they're now redundant. I think I will actually add a couple of
asserts that the types of the display notification actions are as expected
rather than remove the initializations. Thanks for bringing this to my
attention.

[commit-bot: I haz the power, 2016-09-29 16:26:36]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-29 16:30:42]

Description was changed from

==========
Give PlatformNotificationAction's scalar type field a default value

- This fixes the underlying reason for the uninit warning in
PlatformNotificationServiceTest.DisplayPersistentNotificationMatches
by initializing the field in PlatformNotificationAction's constructor.

BUG=599859,651165
==========

to

==========
Give PlatformNotificationAction's scalar type field a default value

- This fixes the underlying reason for the uninit warning in
PlatformNotificationServiceTest.DisplayPersistentNotificationMatches
by initializing the field in PlatformNotificationAction's constructor.

BUG=599859,651165

Committed: https://crrev.com/0463eb5e689328081e71de001f621fefed5b737c
Cr-Commit-Position: refs/heads/master@{#421840}
==========

[commit-bot: I haz the power, 2016-09-29 16:30:44]

Patchset 1 (id:??) landed as
https://crrev.com/0463eb5e689328081e71de001f621fefed5b737c
Cr-Commit-Position: refs/heads/master@{#421840}