[stubs] replaced ToString MacroAssembler Stub with CodeStubAssembler builtin

[stubs] Port ToString platform stub to TurboFan.

R=bmeurer@chromium.org
BUG=

Committed: https://crrev.com/8c87212186107fbe1b02086f87ce90645557865c
Cr-Commit-Position: refs/heads/master@{#39872}

[Tobias Tebbi, 2016-09-29 09:20:43]

I did not remove ToStringStub yet because there are dependencies from other
MacroAssembler stubs.

[Benedikt Meurer, 2016-09-29 11:18:18]

bmeurer@chromium.org changed reviewers:
+ ishell@chromium.org

[Benedikt Meurer, 2016-09-29 11:18:19]

Adding Igor as reviewer.

As discussed offline, please remove the old ToStringStub completely.

https://codereview.chromium.org/2380973002/diff/1/src/builtins/builtins-conve...
File src/builtins/builtins-conversion.cc (right):

https://codereview.chromium.org/2380973002/diff/1/src/builtins/builtins-conve...
src/builtins/builtins-conversion.cc:165:
assembler->GotoIf(assembler->WordIsSmi(input), &runtime);
Smis should go to NumberToString stub, i.e. jump to the is_number case below.

https://codereview.chromium.org/2380973002/diff/1/src/builtins/builtins-conve...
src/builtins/builtins-conversion.cc:182: assembler->IntPtrEqual(input_map,
assembler->HeapNumberMapConstant()),
s/IntPtrEqual/WordEqual/

https://codereview.chromium.org/2380973002/diff/1/src/builtins/builtins-conve...
src/builtins/builtins-conversion.cc:189: Callable callable =
CodeFactory::NumberToString(assembler->isolate());
Add TODO here to inline NumberToString once that's migrated to the
CodeStubAssembler.

[Tobias Tebbi, 2016-09-29 12:56:01]

I am not sure about what I did in the Hydrogen code.

[Benedikt Meurer, 2016-09-29 13:07:34]

Looking good. Please address my earlier comments as well.

https://codereview.chromium.org/2380973002/diff/20001/src/builtins/builtins-c...
File src/builtins/builtins-conversion.cc (right):

https://codereview.chromium.org/2380973002/diff/20001/src/builtins/builtins-c...
src/builtins/builtins-conversion.cc:165:
assembler->GotoIf(assembler->WordIsSmi(input), &runtime);
s/runtime/is_number

[Igor Sheludko, 2016-09-29 13:25:01]

Description was changed from

==========
[turbofan] replaced ToString MacroAssembler Stub with CodeStubAssembler builtin

R=bmeurer@chromium.org
BUG=
==========

to

==========
[stubs] Port ToString platform stub to TurboFan.

R=bmeurer@chromium.org
BUG=
==========

[Igor Sheludko, 2016-09-29 13:37:32]

lgtm once Benedikt's comment is addressed.

[Igor Sheludko, 2016-09-29 13:39:36]

On 2016/09/29 13:37:32, Igor Sheludko wrote:
> lgtm once Benedikt's comment is addressed.

I also updated the CL's description.

[Tobias Tebbi, 2016-09-29 13:49:29]

The CQ bit was checked by tebbi@chromium.org

[Tobias Tebbi, 2016-09-29 13:49:30]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org
Link to the patchset: https://codereview.chromium.org/2380973002/#ps40001
(title: "addressed comments")

[commit-bot: I haz the power, 2016-09-29 13:49:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 13:52:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 13:52:11]

Try jobs failed on following builders:
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/9919)

[Tobias Tebbi, 2016-09-29 14:04:26]

The CQ bit was checked by tebbi@chromium.org

[Tobias Tebbi, 2016-09-29 14:04:27]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org
Link to the patchset: https://codereview.chromium.org/2380973002/#ps60001
(title: "Merge branch 'master' of https://chromium.googlesource.com/v8/v8 into
ToStringTFStub")

[commit-bot: I haz the power, 2016-09-29 14:04:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 14:50:52]

Description was changed from

==========
[stubs] Port ToString platform stub to TurboFan.

R=bmeurer@chromium.org
BUG=
==========

to

==========
[stubs] Port ToString platform stub to TurboFan.

R=bmeurer@chromium.org
BUG=
==========

[commit-bot: I haz the power, 2016-09-29 14:50:53]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-29 14:51:11]

Description was changed from

==========
[stubs] Port ToString platform stub to TurboFan.

R=bmeurer@chromium.org
BUG=
==========

to

==========
[stubs] Port ToString platform stub to TurboFan.

R=bmeurer@chromium.org
BUG=

Committed: https://crrev.com/8c87212186107fbe1b02086f87ce90645557865c
Cr-Commit-Position: refs/heads/master@{#39872}
==========

[commit-bot: I haz the power, 2016-09-29 14:51:12]

Patchset 4 (id:??) landed as
https://crrev.com/8c87212186107fbe1b02086f87ce90645557865c
Cr-Commit-Position: refs/heads/master@{#39872}