[stubs] replaced ToString MacroAssembler Stub with CodeStubAssembler builtin

src/builtins/builtins-conversion.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/builtins/builtins.h"
 #include "src/builtins/builtins-utils.h"
 #include "src/code-factory.h"
 
 namespace v8 {
 namespace internal {
@@ skipping 133 matching lines @@
 void Builtins::Generate_ToNumber(CodeStubAssembler* assembler) {
   typedef compiler::Node Node;
   typedef TypeConversionDescriptor Descriptor;
 
   Node* input = assembler->Parameter(Descriptor::kArgument);
   Node* context = assembler->Parameter(Descriptor::kContext);
 
   assembler->Return(assembler->ToNumber(context, input));
 }
 
+void Builtins::Generate_ToString(CodeStubAssembler* assembler) {
+  typedef CodeStubAssembler::Label Label;
+  typedef compiler::Node Node;
+  typedef TypeConversionDescriptor Descriptor;
+
+  Node* input = assembler->Parameter(Descriptor::kArgument);
+  Node* context = assembler->Parameter(Descriptor::kContext);
+
+  Label is_number(assembler);
+  Label runtime(assembler);
+
+  assembler->GotoIf(assembler->WordIsSmi(input), &runtime);

[Benedikt Meurer, 2016/09/29 11:18:18]

Smis should go to NumberToString stub, i.e. jump to the is_number case below.

+
+  Node* input_map = assembler->LoadMap(input);
+  Node* input_instance_type = assembler->LoadMapInstanceType(input_map);
+
+  Label not_string(assembler);
+  assembler->GotoIf(
+      assembler->Int32GreaterThanOrEqual(
+          input_instance_type, assembler->Int32Constant(FIRST_NONSTRING_TYPE)),
+      &not_string);
+  assembler->Return(input);
+
+  Label not_heap_number(assembler);
+
+  assembler->Bind(&not_string);
+  {
+    assembler->GotoUnless(
+        assembler->IntPtrEqual(input_map, assembler->HeapNumberMapConstant()),

[Benedikt Meurer, 2016/09/29 11:18:18]

s/IntPtrEqual/WordEqual/

+        &not_heap_number);
+    assembler->Goto(&is_number);
+  }
+
+  assembler->Bind(&is_number);
+  {
+    Callable callable = CodeFactory::NumberToString(assembler->isolate());

[Benedikt Meurer, 2016/09/29 11:18:18]

Add TODO here to inline NumberToString once that's migrated to the
CodeStubAssembler.

+    assembler->Return(assembler->CallStub(callable, context, input));
+  }
+
+  assembler->Bind(&not_heap_number);
+  {
+    assembler->GotoIf(
+        assembler->Word32NotEqual(input_instance_type,
+                                  assembler->Int32Constant(ODDBALL_TYPE)),
+        &runtime);
+    assembler->Return(
+        assembler->LoadObjectField(input, Oddball::kToStringOffset));
+  }
+
+  assembler->Bind(&runtime);
+  {
+    assembler->Return(
+        assembler->CallRuntime(Runtime::kToString, context, input));
+  }
+}
+
 Handle<Code> Builtins::OrdinaryToPrimitive(OrdinaryToPrimitiveHint hint) {
   switch (hint) {
     case OrdinaryToPrimitiveHint::kNumber:
       return OrdinaryToPrimitive_Number();
     case OrdinaryToPrimitiveHint::kString:
       return OrdinaryToPrimitive_String();
   }
   UNREACHABLE();
   return Handle<Code>::null();
 }
@@ skipping 95 matching lines @@
 
   assembler->Bind(&return_true);
   assembler->Return(assembler->BooleanConstant(true));
 
   assembler->Bind(&return_false);
   assembler->Return(assembler->BooleanConstant(false));
 }
 
 }  // namespace internal
 }  // namespace v8