Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 238093002: Revert 263726 "x11: Remove X11 message-pump." (Closed)

Created:
6 years, 8 months ago by Ami GONE FROM CHROMIUM
Modified:
6 years, 8 months ago
Reviewers:
sadrul
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 263726 "x11: Remove X11 message-pump." Reason for revert: along with 263718 blamed for http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%282%29/builds/45298 http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/29956 > x11: Remove X11 message-pump. > > The remaining use of the X11 mesage-pump was opening the connection to the > X11 server. This patch moves that out of the message-pump, into gfx. This > allows us to remove the X11 message-pump, and just use the base Glib-based > message-pump on Linux and ChromeOS. > > BUG=354062 > R=darin@chromium.org, sky@chromium.org > > Review URL: https://codereview.chromium.org/235043005 TBR=sadrul@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263733

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -116 lines) Patch
M trunk/src/ash/shell.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/test/ash_test_base.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/ash/wm/ash_native_cursor_manager_interactive_uitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/base/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/base/base.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/base/base.gypi View 2 chunks +6 lines, -0 lines 0 comments Download
M trunk/src/base/message_loop/message_loop.h View 4 chunks +20 lines, -3 lines 0 comments Download
M trunk/src/base/message_loop/message_pump_glib.h View 1 chunk +0 lines, -2 lines 0 comments Download
A + trunk/src/base/message_loop/message_pump_x11.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/base/message_loop/message_pump_x11.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/chrome/browser/ui/libgtk2ui/gtk2_event_loop.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/libgtk2ui/x11_input_method_context_impl_gtk2.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/content/browser/browser_main_loop.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/content/browser/power_save_blocker_x11.cc View 2 chunks +2 lines, -1 line 0 comments Download
M trunk/src/content/common/gpu/media/rendering_helper.cc View 3 chunks +2 lines, -6 lines 0 comments Download
M trunk/src/content/content_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/gpu/config/gpu_info_collector_x11.cc View 2 chunks +1 line, -2 lines 0 comments Download
M trunk/src/ui/aura/aura.gyp View 2 chunks +0 lines, -14 lines 0 comments Download
M trunk/src/ui/aura/bench/bench_main.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M trunk/src/ui/aura/demo/demo_main.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M trunk/src/ui/base/x/selection_requestor.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ui/base/x/x11_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/ui/display/chromeos/x11/touchscreen_delegate_x11.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D trunk/src/ui/display/x11/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/ui/display/x11/edid_parser_x11.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M trunk/src/ui/events/x/events_x.cc View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/ui/gfx/gfx.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D trunk/src/ui/gfx/x/x11_connection.h View 1 chunk +0 lines, -18 lines 0 comments Download
D trunk/src/ui/gfx/x/x11_connection.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M trunk/src/ui/gfx/x/x11_types.cc View 1 chunk +1 line, -4 lines 0 comments Download
M trunk/src/ui/gl/gl_image_glx.cc View 2 chunks +1 line, -2 lines 0 comments Download
M trunk/src/ui/gl/gl_surface_glx.cc View 2 chunks +16 lines, -3 lines 0 comments Download
M trunk/src/ui/gl/gl_surface_x11.cc View 4 chunks +3 lines, -4 lines 0 comments Download
M trunk/src/ui/views/examples/examples_main.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M trunk/src/ui/views/test/ui_controls_factory_desktop_aurax11.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M trunk/src/ui/views/widget/desktop_aura/desktop_screen_x11.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/ui/views/widget/desktop_aura/x11_desktop_window_move_client.cc View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ami GONE FROM CHROMIUM
6 years, 8 months ago (2014-04-14 22:39:08 UTC) #1
Ami GONE FROM CHROMIUM
6 years, 8 months ago (2014-04-14 22:45:21 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r263733 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698