Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 235043005: x11: Remove X11 message-pump. (Closed)

Created:
6 years, 8 months ago by sadrul
Modified:
6 years, 8 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, derat+watch_chromium.org, tfarina, ben+aura_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, piman+watch_chromium.org, kalyank, ben+views_chromium.org, erikwright+watch_chromium.org, stevenjb+watch_chromium.org, ben+ash_chromium.org
Visibility:
Public.

Description

x11: Remove X11 message-pump. The remaining use of the X11 mesage-pump was opening the connection to the X11 server. This patch moves that out of the message-pump, into gfx. This allows us to remove the X11 message-pump, and just use the base Glib-based message-pump on Linux and ChromeOS. BUG=354062 R=darin@chromium.org, sky@chromium.org Previously landed in r263726, but reverted in r263733 to allow reverting another CL. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263777

Patch Set 1 #

Patch Set 2 : fix-linux #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Total comments: 2

Patch Set 7 : . #

Patch Set 8 : tot-merge #

Patch Set 9 : tot-merge #

Patch Set 10 : prepare-for-reland #

Patch Set 11 : tot-merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -193 lines) Patch
M ash/shell.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M ash/test/ash_test_base.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/ash_native_cursor_manager_interactive_uitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/BUILD.gn View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M base/base.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M base/base.gypi View 2 chunks +0 lines, -6 lines 0 comments Download
M base/message_loop/message_loop.h View 1 2 3 4 4 chunks +3 lines, -20 lines 0 comments Download
M base/message_loop/message_pump_glib.h View 1 chunk +2 lines, -0 lines 0 comments Download
D base/message_loop/message_pump_x11.h View 1 chunk +0 lines, -42 lines 0 comments Download
D base/message_loop/message_pump_x11.cc View 1 chunk +0 lines, -63 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/gtk2_event_loop.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/x11_input_method_context_impl_gtk2.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/browser_main_loop.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/power_save_blocker_x11.cc View 2 chunks +1 line, -2 lines 0 comments Download
M content/common/gpu/media/rendering_helper.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 4 5 6 8 1 chunk +1 line, -0 lines 0 comments Download
M gpu/config/gpu_info_collector_x11.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/aura/aura.gyp View 2 chunks +14 lines, -0 lines 0 comments Download
M ui/aura/bench/bench_main.cc View 1 2 3 4 5 6 3 chunks +2 lines, -5 lines 0 comments Download
M ui/aura/demo/demo_main.cc View 1 2 3 4 5 6 3 chunks +2 lines, -6 lines 0 comments Download
M ui/base/x/selection_requestor.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/x/x11_util.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M ui/display/chromeos/x11/touchscreen_delegate_x11.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + ui/display/x11/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M ui/display/x11/edid_parser_x11.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ui/events/x/events_x.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/gfx.gyp View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -0 lines 0 comments Download
A ui/gfx/x/x11_connection.h View 1 2 3 4 5 6 1 chunk +18 lines, -0 lines 0 comments Download
A ui/gfx/x/x11_connection.cc View 1 2 3 4 5 6 1 chunk +17 lines, -0 lines 0 comments Download
M ui/gfx/x/x11_types.cc View 1 chunk +4 lines, -1 line 0 comments Download
M ui/gl/gl_image_glx.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/gl/gl_surface_glx.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +3 lines, -3 lines 0 comments Download
M ui/gl/gl_surface_x11.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M ui/views/examples/examples_main.cc View 1 2 3 4 5 6 3 chunks +6 lines, -5 lines 0 comments Download
M ui/views/test/ui_controls_factory_desktop_aurax11.cc View 1 2 3 4 5 6 2 chunks +4 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_x11.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/x11_desktop_window_move_client.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
sadrul
6 years, 8 months ago (2014-04-11 20:39:52 UTC) #1
darin (slow to review)
LGTM (whole CL) https://codereview.chromium.org/235043005/diff/120001/ui/gfx/x/x11_connection.cc File ui/gfx/x/x11_connection.cc (right): https://codereview.chromium.org/235043005/diff/120001/ui/gfx/x/x11_connection.cc#newcode14 ui/gfx/x/x11_connection.cc:14: return XInitThreads() && gfx::GetXDisplay(); Want to ...
6 years, 8 months ago (2014-04-12 16:37:19 UTC) #2
sky
LGTM
6 years, 8 months ago (2014-04-14 14:34:14 UTC) #3
sadrul
https://codereview.chromium.org/235043005/diff/120001/ui/gfx/x/x11_connection.cc File ui/gfx/x/x11_connection.cc (right): https://codereview.chromium.org/235043005/diff/120001/ui/gfx/x/x11_connection.cc#newcode14 ui/gfx/x/x11_connection.cc:14: return XInitThreads() && gfx::GetXDisplay(); On 2014/04/12 16:37:19, darin wrote: ...
6 years, 8 months ago (2014-04-14 20:37:55 UTC) #4
sadrul
Committed patchset #9 manually as r263726 (presubmit successful).
6 years, 8 months ago (2014-04-14 21:13:28 UTC) #5
sadrul
6 years, 8 months ago (2014-04-15 03:34:59 UTC) #6
Message was sent while issue was closed. 
Committed patchset #11 manually as r263777 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698