4 years, 2 months ago
(2016-09-28 22:15:22 UTC)
#4
Message was sent while issue was closed.
Committed patchset #1 (id:1)
commit-bot: I haz the power
Description was changed from ========== Revert of Update image and text color when row is ...
4 years, 2 months ago
(2016-09-28 22:17:10 UTC)
#5
Message was sent while issue was closed.
Description was changed from
==========
Revert of Update image and text color when row is selected in the chooser on Mac
(patchset #8 id:140001 of https://codereview.chromium.org/2342723002/ )
Reason for revert:
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Mac%20ASan%20...
Original issue's description:
> Update image and text color when row is selected in the chooser on Mac
>
> This CL added code to change the image and text color in the chooser row
> when it is selected so that it is more visible.
>
> 1. changed text from black to white when row is selected.
> 2. changed image from black to white when row is selected.
> 3. changed "Paired" text color to use gfx::kGoogleGreen300 when row is
selected.
>
> I uploaded screenshots to the issue page.
>
> BUG=645693
>
> Committed: https://crrev.com/188a5ae80ab8cca65c8c987a5bfb8a37e33a773e
> Cr-Commit-Position: refs/heads/master@{#421606}
TBR=oshima@chromium.org,msw@chromium.org,rsesek@chromium.org,jyasskin@chromiu...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=645693
==========
to
==========
Revert of Update image and text color when row is selected in the chooser on Mac
(patchset #8 id:140001 of https://codereview.chromium.org/2342723002/ )
Reason for revert:
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Mac%20ASan%20...
Original issue's description:
> Update image and text color when row is selected in the chooser on Mac
>
> This CL added code to change the image and text color in the chooser row
> when it is selected so that it is more visible.
>
> 1. changed text from black to white when row is selected.
> 2. changed image from black to white when row is selected.
> 3. changed "Paired" text color to use gfx::kGoogleGreen300 when row is
selected.
>
> I uploaded screenshots to the issue page.
>
> BUG=645693
>
> Committed: https://crrev.com/188a5ae80ab8cca65c8c987a5bfb8a37e33a773e
> Cr-Commit-Position: refs/heads/master@{#421606}
TBR=oshima@chromium.org,msw@chromium.org,rsesek@chromium.org,jyasskin@chromiu...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=645693
Committed: https://crrev.com/b52737bdec74fd1a9d91b1a30f4ba10c9694a5ff
Cr-Commit-Position: refs/heads/master@{#421656}
==========
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b52737bdec74fd1a9d91b1a30f4ba10c9694a5ff Cr-Commit-Position: refs/heads/master@{#421656}
4 years, 2 months ago
(2016-09-28 22:17:11 UTC)
#6
Issue 2380903002: Revert of Update image and text color when row is selected in the chooser on Mac
(Closed)
Created 4 years, 2 months ago by juncai
Modified 4 years, 2 months ago
Reviewers: oshima, msw, Robert Sesek, Jeffrey Yasskin, sky
Base URL:
Comments: 0