Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Issue 2380903002: Revert of Update image and text color when row is selected in the chooser on Mac (Closed)

Created:
4 years, 2 months ago by juncai
Modified:
4 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, oshima+watch_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update image and text color when row is selected in the chooser on Mac (patchset #8 id:140001 of https://codereview.chromium.org/2342723002/ ) Reason for revert: https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/22266 Original issue's description: > Update image and text color when row is selected in the chooser on Mac > > This CL added code to change the image and text color in the chooser row > when it is selected so that it is more visible. > > 1. changed text from black to white when row is selected. > 2. changed image from black to white when row is selected. > 3. changed "Paired" text color to use gfx::kGoogleGreen300 when row is selected. > > I uploaded screenshots to the issue page. > > BUG=645693 > > Committed: https://crrev.com/188a5ae80ab8cca65c8c987a5bfb8a37e33a773e > Cr-Commit-Position: refs/heads/master@{#421606} TBR=oshima@chromium.org,msw@chromium.org,rsesek@chromium.org,jyasskin@chromium.org,sky@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=645693 Committed: https://crrev.com/b52737bdec74fd1a9d91b1a30f4ba10c9694a5ff Cr-Commit-Position: refs/heads/master@{#421656}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -279 lines) Patch
M chrome/browser/chooser_controller/mock_chooser_controller.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chooser_controller/mock_chooser_controller.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/chooser_content_view_cocoa.h View 1 chunk +3 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/chooser_content_view_cocoa.mm View 3 chunks +0 lines, -48 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm View 16 chunks +25 lines, -213 lines 0 comments Download
M chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm View 1 chunk +0 lines, -1 line 0 comments Download
D ui/resources/default_100_percent/common/signal_0_bar_selected.png View Binary file 0 comments Download
M ui/resources/default_100_percent/common/signal_1_bar.png View Binary file 0 comments Download
D ui/resources/default_100_percent/common/signal_1_bar_selected.png View Binary file 0 comments Download
M ui/resources/default_100_percent/common/signal_2_bar.png View Binary file 0 comments Download
D ui/resources/default_100_percent/common/signal_2_bar_selected.png View Binary file 0 comments Download
M ui/resources/default_100_percent/common/signal_3_bar.png View Binary file 0 comments Download
D ui/resources/default_100_percent/common/signal_3_bar_selected.png View Binary file 0 comments Download
D ui/resources/default_100_percent/common/signal_4_bar_selected.png View Binary file 0 comments Download
D ui/resources/default_200_percent/common/signal_0_bar_selected.png View Binary file 0 comments Download
D ui/resources/default_200_percent/common/signal_1_bar_selected.png View Binary file 0 comments Download
M ui/resources/default_200_percent/common/signal_2_bar.png View Binary file 0 comments Download
D ui/resources/default_200_percent/common/signal_2_bar_selected.png View Binary file 0 comments Download
D ui/resources/default_200_percent/common/signal_3_bar_selected.png View Binary file 0 comments Download
D ui/resources/default_200_percent/common/signal_4_bar_selected.png View Binary file 0 comments Download
M ui/resources/ui_resources.grd View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
juncai
Created Revert of Update image and text color when row is selected in the chooser ...
4 years, 2 months ago (2016-09-28 22:13:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2380903002/1
4 years, 2 months ago (2016-09-28 22:14:09 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-28 22:15:22 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 22:17:11 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b52737bdec74fd1a9d91b1a30f4ba10c9694a5ff
Cr-Commit-Position: refs/heads/master@{#421656}

Powered by Google App Engine
This is Rietveld 408576698