Add PlzNavigate run of browser_tests to main linux config

Add PlzNavigate run of browser_tests to main linux config

R=dpranke@chromium.org
BUG=504347
Committed: https://crrev.com/0c46e36075fcaa458c81fcae19bd321a2fb38bbd
Cr-Commit-Position: refs/heads/master@{#421998}

[scottmg, 2016-09-28 22:09:07]

The CQ bit was checked by scottmg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 22:09:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scottmg, 2016-09-28 22:12:28]

Mailed infra to confirm that capacity will be OK for this one.

[Dirk Pranke, 2016-09-28 22:17:40]

lgtm.

same suggestion re (dbg) (i.e., maybe add it).

[scottmg, 2016-09-28 22:20:38]

On 2016/09/28 22:17:40, Dirk Pranke wrote:
> lgtm.
> 
> same suggestion re (dbg) (i.e., maybe add it).

Thanks, I'll wait for confirmation that we're not going to overload swarming
before landing.

[commit-bot: I haz the power, 2016-09-28 23:00:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 23:00:20]

Dry run: This issue passed the CQ dry run.

[scottmg, 2016-09-29 23:22:51]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2016-09-29 23:23:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2016-09-29 23:25:03]

On 2016/09/28 22:20:38, scottmg wrote:
> On 2016/09/28 22:17:40, Dirk Pranke wrote:
> > lgtm.
> > 
> > same suggestion re (dbg) (i.e., maybe add it).
> 
> Thanks, I'll wait for confirmation that we're not going to overload swarming
> before landing.

Just saw this and the other change.

We have to have parity between release and linux on main waterfall. Otherwise a
DCHECK could be firing, which would block CQ (release-with-asserts) but it would
be invisible on the main waterfall to sheriffs. this has bitten us a bunch of
times before.

So please add browser_tests and content_unittests in this patch to linux debug

[jam, 2016-09-29 23:25:50]

On 2016/09/29 23:25:03, jam wrote:
> On 2016/09/28 22:20:38, scottmg wrote:
> > On 2016/09/28 22:17:40, Dirk Pranke wrote:
> > > lgtm.
> > > 
> > > same suggestion re (dbg) (i.e., maybe add it).
> > 
> > Thanks, I'll wait for confirmation that we're not going to overload swarming
> > before landing.
> 
> Just saw this and the other change.
> 
> We have to have parity between release and linux on main waterfall. Otherwise
a
> DCHECK could be firing, which would block CQ (release-with-asserts) but it
would
> be invisible on the main waterfall to sheriffs. this has bitten us a bunch of
> times before.
> 
> So please add browser_tests and content_unittests in this patch to linux debug

meant to say "release and debug" :)

[scottmg, 2016-09-29 23:33:30]

On 2016/09/29 23:25:50, jam wrote:
> On 2016/09/29 23:25:03, jam wrote:
> > On 2016/09/28 22:20:38, scottmg wrote:
> > > On 2016/09/28 22:17:40, Dirk Pranke wrote:
> > > > lgtm.
> > > > 
> > > > same suggestion re (dbg) (i.e., maybe add it).
> > > 
> > > Thanks, I'll wait for confirmation that we're not going to overload
swarming
> > > before landing.
> > 
> > Just saw this and the other change.
> > 
> > We have to have parity between release and linux on main waterfall.
Otherwise
> a
> > DCHECK could be firing, which would block CQ (release-with-asserts) but it
> would
> > be invisible on the main waterfall to sheriffs. this has bitten us a bunch
of
> > times before.
> > 
> > So please add browser_tests and content_unittests in this patch to linux
debug
> 
> meant to say "release and debug" :)

Oh, the Release bots aren't dcheck_always_on any more? Or are you saying they
are but only on trybots not waterfall? O_o

[jam, 2016-09-29 23:36:18]

On 2016/09/29 23:33:30, scottmg wrote:
> On 2016/09/29 23:25:50, jam wrote:
> > On 2016/09/29 23:25:03, jam wrote:
> > > On 2016/09/28 22:20:38, scottmg wrote:
> > > > On 2016/09/28 22:17:40, Dirk Pranke wrote:
> > > > > lgtm.
> > > > > 
> > > > > same suggestion re (dbg) (i.e., maybe add it).
> > > > 
> > > > Thanks, I'll wait for confirmation that we're not going to overload
> swarming
> > > > before landing.
> > > 
> > > Just saw this and the other change.
> > > 
> > > We have to have parity between release and linux on main waterfall.
> Otherwise
> > a
> > > DCHECK could be firing, which would block CQ (release-with-asserts) but it
> > would
> > > be invisible on the main waterfall to sheriffs. this has bitten us a bunch
> of
> > > times before.
> > > 
> > > So please add browser_tests and content_unittests in this patch to linux
> debug
> > 
> > meant to say "release and debug" :)
> 
> Oh, the Release bots aren't dcheck_always_on any more? Or are you saying they
> are but only on trybots not waterfall? O_o

Right, only on CQ do we have release-with-asserts.

[scottmg, 2016-09-29 23:41:09]

On 2016/09/29 23:36:18, jam wrote:
> On 2016/09/29 23:33:30, scottmg wrote:
> > On 2016/09/29 23:25:50, jam wrote:
> > > On 2016/09/29 23:25:03, jam wrote:
> > > > On 2016/09/28 22:20:38, scottmg wrote:
> > > > > On 2016/09/28 22:17:40, Dirk Pranke wrote:
> > > > > > lgtm.
> > > > > > 
> > > > > > same suggestion re (dbg) (i.e., maybe add it).
> > > > > 
> > > > > Thanks, I'll wait for confirmation that we're not going to overload
> > swarming
> > > > > before landing.
> > > > 
> > > > Just saw this and the other change.
> > > > 
> > > > We have to have parity between release and linux on main waterfall.
> > Otherwise
> > > a
> > > > DCHECK could be firing, which would block CQ (release-with-asserts) but
it
> > > would
> > > > be invisible on the main waterfall to sheriffs. this has bitten us a
bunch
> > of
> > > > times before.
> > > > 
> > > > So please add browser_tests and content_unittests in this patch to linux
> > debug
> > > 
> > > meant to say "release and debug" :)
> > 
> > Oh, the Release bots aren't dcheck_always_on any more? Or are you saying
they
> > are but only on trybots not waterfall? O_o
> 
> Right, only on CQ do we have release-with-asserts.

Alllllrighty. Updated this one for browser_tests and
https://codereview.chromium.org/2381203002 for the others that are out of sync.

[jam, 2016-09-29 23:42:31]

jam@chromium.org changed reviewers:
+ jam@chromium.org

[jam, 2016-09-29 23:42:31]

lgtm with nit

https://codereview.chromium.org/2380893002/diff/20001/testing/buildbot/chromi...
File testing/buildbot/chromium.linux.json (right):

https://codereview.chromium.org/2380893002/diff/20001/testing/buildbot/chromi...
testing/buildbot/chromium.linux.json:2274: "shards": 5
nit: 10 to match above (we shard debug more because it's slower)

[scottmg, 2016-09-29 23:43:28]

https://codereview.chromium.org/2380893002/diff/20001/testing/buildbot/chromi...
File testing/buildbot/chromium.linux.json (right):

https://codereview.chromium.org/2380893002/diff/20001/testing/buildbot/chromi...
testing/buildbot/chromium.linux.json:2274: "shards": 5
On 2016/09/29 23:42:31, jam wrote:
> nit: 10 to match above (we shard debug more because it's slower)

Done.

[scottmg, 2016-09-29 23:43:58]

The CQ bit was checked by scottmg@chromium.org

[scottmg, 2016-09-29 23:43:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, jam@chromium.org
Link to the patchset: https://codereview.chromium.org/2380893002/#ps40001
(title: "10")

[commit-bot: I haz the power, 2016-09-29 23:44:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 00:43:32]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-30 00:50:11]

Description was changed from

==========
Add PlzNavigate run of browser_tests to main linux config

R=dpranke@chromium.org
BUG=504347
==========

to

==========
Add PlzNavigate run of browser_tests to main linux config

R=dpranke@chromium.org
BUG=504347

Committed: https://crrev.com/0c46e36075fcaa458c81fcae19bd321a2fb38bbd
Cr-Commit-Position: refs/heads/master@{#421998}
==========

[commit-bot: I haz the power, 2016-09-30 00:50:13]

Patchset 3 (id:??) landed as
https://crrev.com/0c46e36075fcaa458c81fcae19bd321a2fb38bbd
Cr-Commit-Position: refs/heads/master@{#421998}

[Kunihiko Sakamoto, 2016-09-30 06:33:22]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2378973004/ by ksakamoto@chromium.org.

The reason for reverting is: browser_side_navigation_browser_test is
consistently failing on Linux Tests (dbg)(1) bot

https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests%...
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests%...
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests%...
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests%...
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests%...
.