Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2232)

Unified Diff: content/public/browser/navigation_handle.h

Issue 2380773002: Prevent tracking metrics for cases such as 204s and downloads. (Closed)
Patch Set: fix comment, and disable tests for browser side navigation Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/navigation_handle.h
diff --git a/content/public/browser/navigation_handle.h b/content/public/browser/navigation_handle.h
index f01f0748dd670f44cfcce4e25f46fb0e43a80acd..8770777171da92bf15cb92d1d4a0117004c22115 100644
--- a/content/public/browser/navigation_handle.h
+++ b/content/public/browser/navigation_handle.h
@@ -159,10 +159,11 @@ class CONTENT_EXPORT NavigationHandle {
// GetNetErrorCode will be net::OK.
virtual bool IsErrorPage() = 0;
- // Returns the response headers for the request or nullptr if there are none.
- // This should only be accessed after a redirect was encountered or after the
- // navigation is ready to commit. The headers returned should not be modified,
- // as modifications will not be reflected in the network stack.
+ // Returns the response headers for the request, or nullptr if there aren't
+ // any response headers or they have not been received yet. The response
+ // headers may change during the navigation (e.g. after encountering a server
+ // redirect). The headers returned should not be modified, as modifications
+ // will not be reflected in the network stack.
virtual const net::HttpResponseHeaders* GetResponseHeaders() = 0;
// Resumes a navigation that was previously deferred by a NavigationThrottle.

Powered by Google App Engine
This is Rietveld 408576698