content/browser/frame_host/navigation_handle_impl.cc - Issue 2380773002: Prevent tracking metrics for cases such as 204s and downloads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_handle_impl.cc

Issue 2380773002: Prevent tracking metrics for cases such as 204s and downloads. (Closed)

Patch Set: fix comment, and disable tests for browser side navigation Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/navigation_handle_impl.cc

diff --git a/content/browser/frame_host/navigation_handle_impl.cc b/content/browser/frame_host/navigation_handle_impl.cc

index 53c566373592ee72bfa79b6a6cd4782fb7479580..83172cdfe19f5b6d7dbbcc59061d30f5f2c63b6d 100644

--- a/content/browser/frame_host/navigation_handle_impl.cc

+++ b/content/browser/frame_host/navigation_handle_impl.cc

@@ -221,7 +221,6 @@ bool NavigationHandleImpl::IsSamePage() {

}

const net::HttpResponseHeaders* NavigationHandleImpl::GetResponseHeaders() {

- DCHECK_GE(state_, WILL_REDIRECT_REQUEST);

return response_headers_.get();

}