Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2380763002: Adjust positioning of website settings popup for Harmony. (Closed)

Created:
4 years, 2 months ago by Evan Stade
Modified:
4 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, groby+bubble_chromium.org, rouslan+bubble_chromium.org, msw+watch_chromium.org, hcarmona+bubble_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adjust positioning of website settings popup for Harmony. BUG=635172 Committed: https://crrev.com/f6871304c12899a16a5931446c4cea8ec077f422 Cr-Commit-Position: refs/heads/master@{#421940}

Patch Set 1 #

Patch Set 2 : typo #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -14 lines) Patch
M chrome/browser/ui/layout_constants.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc View 1 1 chunk +5 lines, -9 lines 0 comments Download
M ui/views/bubble/bubble_border.cc View 1 chunk +8 lines, -4 lines 2 comments Download

Messages

Total messages: 10 (3 generated)
Evan Stade
4 years, 2 months ago (2016-09-28 22:33:45 UTC) #2
sky
https://codereview.chromium.org/2380763002/diff/20001/ui/views/bubble/bubble_border.cc File ui/views/bubble/bubble_border.cc (right): https://codereview.chromium.org/2380763002/diff/20001/ui/views/bubble/bubble_border.cc#newcode200 ui/views/bubble/bubble_border.cc:200: if (arrow_ == TOP_LEFT) { Does this do the ...
4 years, 2 months ago (2016-09-29 03:19:54 UTC) #3
Evan Stade
https://codereview.chromium.org/2380763002/diff/20001/ui/views/bubble/bubble_border.cc File ui/views/bubble/bubble_border.cc (right): https://codereview.chromium.org/2380763002/diff/20001/ui/views/bubble/bubble_border.cc#newcode200 ui/views/bubble/bubble_border.cc:200: if (arrow_ == TOP_LEFT) { On 2016/09/29 03:19:54, sky ...
4 years, 2 months ago (2016-09-29 17:27:53 UTC) #4
sky
LGTM
4 years, 2 months ago (2016-09-29 18:29:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2380763002/20001
4 years, 2 months ago (2016-09-29 20:44:00 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-29 21:33:02 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 21:36:45 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/f6871304c12899a16a5931446c4cea8ec077f422
Cr-Commit-Position: refs/heads/master@{#421940}

Powered by Google App Engine
This is Rietveld 408576698