Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3469)

Unified Diff: chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc

Issue 2380763002: Adjust positioning of website settings popup for Harmony. (Closed)
Patch Set: typo Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc
diff --git a/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc b/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc
index 4cb09b8a52739c3077d25a2d243c51836cc19c3b..b625633bc86d81ee933f72a63c71017cc7b923e5 100644
--- a/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc
+++ b/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc
@@ -61,15 +61,11 @@ LocationBarBubbleDelegateView::LocationBarBubbleDelegateView(
content::Source<FullscreenController>(
browser->exclusive_access_manager()->fullscreen_controller()));
}
- if (ui::MaterialDesignController::IsSecondaryUiMaterial()) {
- // The anchor is the location bar. The bubble's 1px border should overlap
- // the location bar's 1px border.
- set_anchor_view_insets(gfx::Insets(0, 0, 1, 0));
- } else {
- // Compensate for built-in vertical padding in the anchor view's image.
- set_anchor_view_insets(gfx::Insets(
- GetLayoutConstant(LOCATION_BAR_BUBBLE_ANCHOR_VERTICAL_INSET), 0));
- }
+ // Compensate for built-in vertical padding in the anchor view's image.
+ // In the case of Harmony, this is just compensating for the location bar's
+ // border thickness, as the bubble's top border should overlap it.
+ set_anchor_view_insets(gfx::Insets(
+ GetLayoutConstant(LOCATION_BAR_BUBBLE_ANCHOR_VERTICAL_INSET), 0));
}
LocationBarBubbleDelegateView::~LocationBarBubbleDelegateView() {}

Powered by Google App Engine
This is Rietveld 408576698