Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2380743004: media: Remove Browser CDM implementation (Closed)

Created:
4 years, 2 months ago by xhwang
Modified:
4 years, 2 months ago
CC:
avayvod+watch_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, eme-reviews_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch+vc_chromium.org, miu+watch_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-media_chromium.org, nasko+codewatch_chromium.org, posciak+watch_chromium.org, slan
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Remove Browser CDM implementation This has been superceded by mojo CDM. BUG=581746, 570711 TEST=This removes an obsolete code path. Committed: https://crrev.com/aff81aab2643bc59e41d5db64a8cbe2e7e66070a Cr-Commit-Position: refs/heads/master@{#422140}

Patch Set 1 #

Patch Set 2 : media: Remove Browser CDM implementation #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1799 lines) Patch
M build/config/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M build/config/features.gni View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/BUILD.gn View 1 1 chunk +0 lines, -7 lines 0 comments Download
M content/browser/media/android/media_web_contents_observer_android.h View 2 chunks +0 lines, -6 lines 0 comments Download
M content/browser/media/android/media_web_contents_observer_android.cc View 5 chunks +0 lines, -59 lines 0 comments Download
D content/browser/media/cdm/browser_cdm_manager.h View 1 chunk +0 lines, -218 lines 0 comments Download
D content/browser/media/cdm/browser_cdm_manager.cc View 1 chunk +0 lines, -716 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 1 2 chunks +0 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 3 chunks +0 lines, -19 lines 0 comments Download
M content/common/media/media_player_messages_android.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/public/browser/render_process_host.h View 1 chunk +0 lines, -7 lines 0 comments Download
M content/public/test/mock_render_process_host.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/public/test/mock_render_process_host.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M content/renderer/BUILD.gn View 1 chunk +0 lines, -9 lines 0 comments Download
M content/renderer/media/android/renderer_media_player_manager.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/media/android/renderer_media_player_manager.cc View 1 2 chunks +0 lines, -10 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.h View 1 chunk +0 lines, -1 line 0 comments Download
D content/renderer/media/cdm/proxy_media_keys.h View 1 chunk +0 lines, -118 lines 0 comments Download
D content/renderer/media/cdm/proxy_media_keys.cc View 1 chunk +0 lines, -191 lines 0 comments Download
M content/renderer/media/cdm/render_cdm_factory.h View 2 chunks +0 lines, -9 lines 2 comments Download
M content/renderer/media/cdm/render_cdm_factory.cc View 3 chunks +0 lines, -12 lines 0 comments Download
D content/renderer/media/cdm/renderer_cdm_manager.h View 1 chunk +0 lines, -120 lines 0 comments Download
D content/renderer/media/cdm/renderer_cdm_manager.cc View 1 chunk +0 lines, -237 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 1 chunk +0 lines, -7 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 4 chunks +3 lines, -14 lines 0 comments Download

Messages

Total messages: 26 (13 generated)
xhwang
PTAL
4 years, 2 months ago (2016-09-30 04:51:27 UTC) #10
xhwang
Nick: Please OWNERS review content/* that's not under a media/ subfolder.
4 years, 2 months ago (2016-09-30 05:55:04 UTC) #12
xhwang
dcheng: Please OWNERS review code removal in content/common/media/media_player_messages_android.h. dpranke: Please OWNERS review code removal in ...
4 years, 2 months ago (2016-09-30 05:58:52 UTC) #13
xhwang
dcheng: Please OWNERS review code removal in content/common/media/media_player_messages_android.h. dpranke: Please OWNERS review code removal in ...
4 years, 2 months ago (2016-09-30 05:59:28 UTC) #15
dcheng
ipc lgtm
4 years, 2 months ago (2016-09-30 06:38:21 UTC) #16
Dirk Pranke
lgtm
4 years, 2 months ago (2016-09-30 16:24:11 UTC) #17
DaleCurtis
media/ lgtm \o/ https://codereview.chromium.org/2380743004/diff/20001/content/renderer/media/cdm/render_cdm_factory.h File content/renderer/media/cdm/render_cdm_factory.h (right): https://codereview.chromium.org/2380743004/diff/20001/content/renderer/media/cdm/render_cdm_factory.h#newcode36 content/renderer/media/cdm/render_cdm_factory.h:36: #endif // defined(ENABLE_PEPPER_CDMS) Can this one ...
4 years, 2 months ago (2016-09-30 16:42:29 UTC) #18
ncarter (slow)
lgtm when deleting code, remember to also comb the bug tracker for obsolete issues that ...
4 years, 2 months ago (2016-09-30 16:52:47 UTC) #19
xhwang
https://codereview.chromium.org/2380743004/diff/20001/content/renderer/media/cdm/render_cdm_factory.h File content/renderer/media/cdm/render_cdm_factory.h (right): https://codereview.chromium.org/2380743004/diff/20001/content/renderer/media/cdm/render_cdm_factory.h#newcode36 content/renderer/media/cdm/render_cdm_factory.h:36: #endif // defined(ENABLE_PEPPER_CDMS) On 2016/09/30 16:42:29, DaleCurtis_OOO_Until_Oct_18 wrote: > ...
4 years, 2 months ago (2016-09-30 17:06:19 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2380743004/20001
4 years, 2 months ago (2016-09-30 17:17:03 UTC) #22
xhwang
slan: FYI
4 years, 2 months ago (2016-09-30 17:17:49 UTC) #23
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-30 17:23:10 UTC) #24
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 17:26:00 UTC) #26
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/aff81aab2643bc59e41d5db64a8cbe2e7e66070a
Cr-Commit-Position: refs/heads/master@{#422140}

Powered by Google App Engine
This is Rietveld 408576698