Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4626)

Unified Diff: chrome/browser/extensions/error_console/error_console.h

Issue 238073002: Provide UI for per-extension enabling/disabling of error collection. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/error_console/error_console.h
diff --git a/chrome/browser/extensions/error_console/error_console.h b/chrome/browser/extensions/error_console/error_console.h
index f2d19eba5434fd1949ab473d66c9b3b846b46eb0..de3bfab33c5acb39d1f6f7d5f742c1f5e49c7ea3 100644
--- a/chrome/browser/extensions/error_console/error_console.h
+++ b/chrome/browser/extensions/error_console/error_console.h
@@ -65,6 +65,10 @@ class ErrorConsole : public content::NotificationObserver,
ExtensionError::Type type,
bool enabled);
+ // Returns true if reporting for either manifest or runtime errors is enabled
+ // for the extension with the given |extension_id|.
+ bool IsReportingEnabledForExtension(const std::string& extension_id) const;
+
// Restore default reporting to the given extension.
void UseDefaultReportingForExtension(const std::string& extension_id);
@@ -138,6 +142,11 @@ class ErrorConsole : public content::NotificationObserver,
const content::NotificationSource& source,
const content::NotificationDetails& details) OVERRIDE;
+ // Returns true if we should report the error of the given type for the
+ // extension.
+ bool ShouldReportErrorForExtension(const std::string& extension_id,
+ ExtensionError::Type type) const;
not at google - send to devlin 2014/04/15 21:57:41 making callers specify |type| all the time is a bi
Devlin 2014/04/16 18:10:48 Different function added.
+
// Whether or not the error console should record errors. This is true if
// the user is in developer mode, and at least one of the following is true:
// - The Chrome Apps Developer Tools are installed.

Powered by Google App Engine
This is Rietveld 408576698