Provide UI for per-extension enabling/disabling of error collection.

chrome/browser/extensions/error_console/error_console.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_ERROR_CONSOLE_ERROR_CONSOLE_H_
 #define CHROME_BROWSER_EXTENSIONS_ERROR_CONSOLE_ERROR_CONSOLE_H_
 
 #include <deque>
 #include <map>
 
@@ skipping 47 matching lines @@
   // Convenience method to return the ErrorConsole for a given profile.
   static ErrorConsole* Get(Profile* profile);
 
   // Set whether or not errors of the specified |type| are stored for the
   // extension with the given |extension_id|. This will be stored in the
   // preferences.
   void SetReportingForExtension(const std::string& extension_id,
                                 ExtensionError::Type type,
                                 bool enabled);
 
+  // Returns true if reporting for either manifest or runtime errors is enabled
+  // for the extension with the given |extension_id|.
+  bool IsReportingEnabledForExtension(const std::string& extension_id) const;
+
   // Restore default reporting to the given extension.
   void UseDefaultReportingForExtension(const std::string& extension_id);
 
   // Report an extension error, and add it to the list.
   void ReportError(scoped_ptr<ExtensionError> error);
 
   // Get a collection of weak pointers to all errors relating to the extension
   // with the given |extension_id|.
   const ErrorList& GetErrorsForExtension(const std::string& extension_id) const;
 
@@ skipping 53 matching lines @@
                                  const Extension* extension) OVERRIDE;
 
   // Add manifest errors from an extension's install warnings.
   void AddManifestErrorsForExtension(const Extension* extension);
 
   // content::NotificationObserver implementation.
   virtual void Observe(int type,
                        const content::NotificationSource& source,
                        const content::NotificationDetails& details) OVERRIDE;
 
+  // Returns true if we should report the error of the given type for the
+  // extension.
+  bool ShouldReportErrorForExtension(const std::string& extension_id,
+                                     ExtensionError::Type type) const;

[not at google - send to devlin, 2014/04/15 21:57:41]

making callers specify |type| all the time is a bit awkward. if you add a new
type (say, install) does that mean you need to update all callers to take it
into account? what is the advantage in having this so flexible? could you
introduce an ALL enum or a different function to set it for everything at once?

[Devlin, 2014/04/16 18:10:48]

Different function added.

+
   // Whether or not the error console should record errors. This is true if
   // the user is in developer mode, and at least one of the following is true:
   // - The Chrome Apps Developer Tools are installed.
   // - FeatureSwitch::error_console() is enabled.
   // - This is a Dev Channel release.
   bool enabled_;
 
   // Needed because ObserverList is not thread-safe.
   base::ThreadChecker thread_checker_;
 
@@ skipping 19 matching lines @@
 
   ScopedObserver<ExtensionRegistry, ExtensionRegistryObserver>
       registry_observer_;
 
   DISALLOW_COPY_AND_ASSIGN(ErrorConsole);
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_ERROR_CONSOLE_ERROR_CONSOLE_H_