[2840 Download Home] More effectively disable Download Home

[2840 Download Home] More effectively disable Download Home

* Consolidate all the places where the Finch flag is checked.

* Cache the Finch flag in SharedPreferences on the off-chance
  that we need it before native has been loaded.  This can
  happen if someone tries to open Download Home via a notification
  after Chrome has died.

* More effectively determine how to open Download Home when
  there's no tab or Activity.

BUG=650727
TBR=ianwen

Original Review-Url: https://codereview.chromium.org/2372313002
Original Cr-Commit-Position: refs/heads/master@{#421683}

Committed: https://chromium.googlesource.com/chromium/src/+/6923a4a997a92d18b64a62d656392a980afa7e02

[gone, 2016-09-29 01:17:57]

Description was changed from

==========
[2840 Download Home] More effectively disable Download Home

* Consolidate all the places where the Finch flag is checked.

* Cache the Finch flag in SharedPreferences on the off-chance
  that we need it before native has been loaded.  This can
  happen if someone tries to open Download Home via a notification
  after Chrome has died.

* More effectively determine how to open Download Home when
  there's no tab or Activity.

BUG=650727

Review-Url: https://codereview.chromium.org/2372313002
Cr-Commit-Position: refs/heads/master@{#421683}
==========

to

==========
[2840 Download Home] More effectively disable Download Home

* Consolidate all the places where the Finch flag is checked.

* Cache the Finch flag in SharedPreferences on the off-chance
  that we need it before native has been loaded.  This can
  happen if someone tries to open Download Home via a notification
  after Chrome has died.

* More effectively determine how to open Download Home when
  there's no tab or Activity.

BUG=650727
TBR=ianwen

Original Review-Url: https://codereview.chromium.org/2372313002
Original Cr-Commit-Position: refs/heads/master@{#421683}
==========

[gone, 2016-09-29 01:17:57]

dfalcantara@chromium.org changed reviewers:
+ ianwen@chromium.org

[gone, 2016-09-29 01:22:36]

Description was changed from

==========
[2840 Download Home] More effectively disable Download Home

* Consolidate all the places where the Finch flag is checked.

* Cache the Finch flag in SharedPreferences on the off-chance
  that we need it before native has been loaded.  This can
  happen if someone tries to open Download Home via a notification
  after Chrome has died.

* More effectively determine how to open Download Home when
  there's no tab or Activity.

BUG=650727
TBR=ianwen

Original Review-Url: https://codereview.chromium.org/2372313002
Original Cr-Commit-Position: refs/heads/master@{#421683}
==========

to

==========
[2840 Download Home] More effectively disable Download Home

* Consolidate all the places where the Finch flag is checked.

* Cache the Finch flag in SharedPreferences on the off-chance
  that we need it before native has been loaded.  This can
  happen if someone tries to open Download Home via a notification
  after Chrome has died.

* More effectively determine how to open Download Home when
  there's no tab or Activity.

BUG=650727
TBR=ianwen

Original Review-Url: https://codereview.chromium.org/2372313002
Original Cr-Commit-Position: refs/heads/master@{#421683}

Committed:
https://chromium.googlesource.com/chromium/src/+/6923a4a997a92d18b64a62d65639...
==========

[gone, 2016-09-29 01:22:38]

Committed patchset #1 (id:1) manually as
6923a4a997a92d18b64a62d656392a980afa7e02 (presubmit successful).