Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Issue 2372313002: [Download Home] More effectively disable Download Home (Closed)

Created:
4 years, 2 months ago by gone
Modified:
4 years, 2 months ago
Reviewers:
Ian Wen
CC:
chromium-reviews, asanka, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Download Home] More effectively disable Download Home * Consolidate all the places where the Finch flag is checked. * Cache the Finch flag in SharedPreferences on the off-chance that we need it before native has been loaded. This can happen if someone tries to open Download Home via a notification after Chrome has died. * More effectively determine how to open Download Home when there's no tab or Activity. BUG=650727 Committed: https://crrev.com/96b3ce4784ea3b764bf5425baa671d15334d373c Cr-Commit-Position: refs/heads/master@{#421683}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebasing #

Messages

Total messages: 11 (5 generated)
gone
4 years, 2 months ago (2016-09-27 19:43:04 UTC) #2
Ian Wen
lgtm! https://chromiumcodereview.appspot.com/2372313002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java File chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java (right): https://chromiumcodereview.appspot.com/2372313002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java#newcode63 chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java:63: public static boolean isDownloadHomeEnabled() { Maybe we should ...
4 years, 2 months ago (2016-09-28 23:00:42 UTC) #4
gone
https://chromiumcodereview.appspot.com/2372313002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java File chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java (right): https://chromiumcodereview.appspot.com/2372313002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java#newcode63 chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java:63: public static boolean isDownloadHomeEnabled() { On 2016/09/28 23:00:41, Ian ...
4 years, 2 months ago (2016-09-28 23:03:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2372313002/20001
4 years, 2 months ago (2016-09-28 23:03:31 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-28 23:42:36 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 23:51:39 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/96b3ce4784ea3b764bf5425baa671d15334d373c
Cr-Commit-Position: refs/heads/master@{#421683}

Powered by Google App Engine
This is Rietveld 408576698