[Download Home] More effectively disable Download Home

[Download Home] More effectively disable Download Home

* Consolidate all the places where the Finch flag is checked.

* Cache the Finch flag in SharedPreferences on the off-chance
  that we need it before native has been loaded.  This can
  happen if someone tries to open Download Home via a notification
  after Chrome has died.

* More effectively determine how to open Download Home when
  there's no tab or Activity.

BUG=650727
Committed: https://crrev.com/96b3ce4784ea3b764bf5425baa671d15334d373c
Cr-Commit-Position: refs/heads/master@{#421683}

[gone, 2016-09-27 19:43:03]

dfalcantara@chromium.org changed reviewers:
+ ianwen@chromium.org

[gone, 2016-09-27 19:43:44]

Description was changed from

==========
[Download Home] More effectively disable Download Home

* Consolidate all the places where the Finch flag is checked.

* Cache the Finch flag in SharedPreferences on the off-chance
  that we need it before native has been loaded.  This can
  happen if someone tries to open Download Home via a notification
  after Chrome has died.

BUG=650727
==========

to

==========
[Download Home] More effectively disable Download Home

* Consolidate all the places where the Finch flag is checked.

* Cache the Finch flag in SharedPreferences on the off-chance
  that we need it before native has been loaded.  This can
  happen if someone tries to open Download Home via a notification
  after Chrome has died.

* More effectively determine how to open Download Home when
  there's no tab or Activity.

BUG=650727
==========

[Ian Wen, 2016-09-28 23:00:42]

lgtm!

https://chromiumcodereview.appspot.com/2372313002/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java
(right):

https://chromiumcodereview.appspot.com/2372313002/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java:63:
public static boolean isDownloadHomeEnabled() {
Maybe we should rename it to downloadsUI instead of downloadhome? This CL is the
first CL that mentions the term "download home".

[gone, 2016-09-28 23:03:03]

https://chromiumcodereview.appspot.com/2372313002/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java
(right):

https://chromiumcodereview.appspot.com/2372313002/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java:63:
public static boolean isDownloadHomeEnabled() {
On 2016/09/28 23:00:41, Ian Wen wrote:
> Maybe we should rename it to downloadsUI instead of downloadhome? This CL is
the
> first CL that mentions the term "download home".

After some offline bikeshedding of names we both disliked, we're keeping this as
is.

[gone, 2016-09-28 23:03:13]

The CQ bit was checked by dfalcantara@chromium.org

[commit-bot: I haz the power, 2016-09-28 23:03:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 23:42:35]

Description was changed from

==========
[Download Home] More effectively disable Download Home

* Consolidate all the places where the Finch flag is checked.

* Cache the Finch flag in SharedPreferences on the off-chance
  that we need it before native has been loaded.  This can
  happen if someone tries to open Download Home via a notification
  after Chrome has died.

* More effectively determine how to open Download Home when
  there's no tab or Activity.

BUG=650727
==========

to

==========
[Download Home] More effectively disable Download Home

* Consolidate all the places where the Finch flag is checked.

* Cache the Finch flag in SharedPreferences on the off-chance
  that we need it before native has been loaded.  This can
  happen if someone tries to open Download Home via a notification
  after Chrome has died.

* More effectively determine how to open Download Home when
  there's no tab or Activity.

BUG=650727
==========

[commit-bot: I haz the power, 2016-09-28 23:42:36]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-28 23:51:38]

Description was changed from

==========
[Download Home] More effectively disable Download Home

* Consolidate all the places where the Finch flag is checked.

* Cache the Finch flag in SharedPreferences on the off-chance
  that we need it before native has been loaded.  This can
  happen if someone tries to open Download Home via a notification
  after Chrome has died.

* More effectively determine how to open Download Home when
  there's no tab or Activity.

BUG=650727
==========

to

==========
[Download Home] More effectively disable Download Home

* Consolidate all the places where the Finch flag is checked.

* Cache the Finch flag in SharedPreferences on the off-chance
  that we need it before native has been loaded.  This can
  happen if someone tries to open Download Home via a notification
  after Chrome has died.

* More effectively determine how to open Download Home when
  there's no tab or Activity.

BUG=650727

Committed: https://crrev.com/96b3ce4784ea3b764bf5425baa671d15334d373c
Cr-Commit-Position: refs/heads/master@{#421683}
==========

[commit-bot: I haz the power, 2016-09-28 23:51:39]

Patchset 2 (id:??) landed as
https://crrev.com/96b3ce4784ea3b764bf5425baa671d15334d373c
Cr-Commit-Position: refs/heads/master@{#421683}